Bug 453835 - Some strings in Info Center were not translated into Brazilian Portuguese
Summary: Some strings in Info Center were not translated into Brazilian Portuguese
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-15 15:09 UTC by D3XT3R
Modified: 2022-07-20 22:19 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.25.4


Attachments
kinfocenter x systemsettings (47.58 KB, image/jpeg)
2022-06-22 19:03 UTC, Luiz Fernando Ranghetti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description D3XT3R 2022-05-15 15:09:17 UTC
Some strings in Info Center were not translated into Brazilian Portuguese

The strings are highlighted in this link => https://imgur.com/a/qHN3BKy
Comment 1 Luiz Fernando Ranghetti 2022-06-22 19:03:13 UTC
Created attachment 150062 [details]
kinfocenter x systemsettings

Hi,

It's not a translationg issue as it happens in all languages but its a bug!

KInfoCenter is a simbolic link to System Settings but some parts of the KAboutData translation did not came from systemsettings as you can see in the screenshot (its the same string one has the translation the other no).

Maybe its related to the kinfocenter.pot only had 2 strings (the translations name and e-mail)
Comment 2 Luiz Fernando Ranghetti 2022-06-24 19:05:44 UTC
Hi,

I've made some tests, if I copy systemsettings.mo to kinfocenter.mo than the About dialog becames translated!
Comment 3 Harald Sitter 2022-06-24 19:26:11 UTC
>    KLocalizedString::setApplicationDomain(binaryName.toUtf8().constData());

supposedly systemsettings should use TRANSLATION_DOMAIN to force correct resolution for its strings rather than relying on the fallback on the dynamic domain. moving bug.
Comment 4 Albert Astals Cid 2022-06-30 21:49:04 UTC
The thing is, why is it using kinfocenter domain? It makes no sense, it should be systemsettings for both "applications"
Comment 5 Bug Janitor Service 2022-06-30 21:55:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/155
Comment 6 Albert Astals Cid 2022-07-20 20:20:53 UTC
Git commit d2a36f1df1069b80bc1676f08e7085c4b6e5e266 by Albert Astals Cid.
Committed on 20/07/2022 at 20:18.
Pushed by aacid into branch 'master'.

Fix showing translations for kinfocenter

There's no kinfocenter app, thus no kinfocenter catalog

M  +1    -1    app/main.cpp

https://invent.kde.org/plasma/systemsettings/commit/d2a36f1df1069b80bc1676f08e7085c4b6e5e266
Comment 7 Albert Astals Cid 2022-07-20 20:22:21 UTC
Git commit d00fac532b581ee97d8ce527d45fd3e25f1f1753 by Albert Astals Cid.
Committed on 20/07/2022 at 20:21.
Pushed by aacid into branch 'Plasma/5.25'.

Fix showing translations for kinfocenter

There's no kinfocenter app, thus no kinfocenter catalog
(cherry picked from commit d2a36f1df1069b80bc1676f08e7085c4b6e5e266)

M  +1    -1    app/main.cpp

https://invent.kde.org/plasma/systemsettings/commit/d00fac532b581ee97d8ce527d45fd3e25f1f1753