Bug 453770 - Incorrect slide transition when applied twice in a row
Summary: Incorrect slide transition when applied twice in a row
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Effects & Transitions (other bugs)
Version First Reported In: 22.04.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-14 10:16 UTC by Guido
Modified: 2022-06-06 20:36 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:
fritzibaby: Brainstorm+


Attachments
slide bug (19.04 KB, application/x-kdenlive)
2022-05-14 10:16 UTC, Guido
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guido 2022-05-14 10:16:41 UTC
Created attachment 148823 [details]
slide bug

SUMMARY
Applying the 'slide' transition in succession on several clips is incorrect the second time (but also the fourth, etc.).


STEPS TO REPRODUCE
1. Add 3 or more clips in a row in the timeline
2. Add slide transition (as a mix on the same track or between different tracks) between clips

OBSERVED RESULT
The first slide transition (between clip 1 and 2) is correct, the second slide transition (between clip 2 and clip 3) is incorrect.

EXPECTED RESULT
All slide transition should work the same

Note: in the case of different tracks I have different behaviours in this cases:

correct:

V3                            [clip 3]
V2               [clip 2]
V1  [clip 1]

First slide correct, second slide wrong

V3                            
V2               [clip 2]
V1  [clip 1]           [clip 3]

Se the attached file
Comment 1 Jean-Baptiste Mardelle 2022-05-20 14:42:23 UTC
Git commit b7437141227e703981355139b0d7b8bd6d9a3667 by Jean-Baptiste Mardelle.
Committed on 20/05/2022 at 14:42.
Pushed by mardelle into branch 'master'.

Fix slide composition going in wrong direction (mix is still todo)

M  +27   -1    src/timeline2/model/timelinemodel.cpp
M  +1    -0    src/timeline2/model/trackmodel.cpp
M  +32   -2    src/timeline2/view/timelinecontroller.cpp

https://invent.kde.org/multimedia/kdenlive/commit/b7437141227e703981355139b0d7b8bd6d9a3667
Comment 2 Jean-Baptiste Mardelle 2022-05-21 15:56:33 UTC
Git commit b0be110a6bbf1a8731c4f01ffda6e370aa2a1ccc by Jean-Baptiste Mardelle.
Committed on 21/05/2022 at 15:56.
Pushed by mardelle into branch 'master'.

Fix Slide mix not correctly updated when creating a new mix on the previous clip, add tests.

M  +125  -22   src/timeline2/model/trackmodel.cpp
M  +4    -0    src/timeline2/model/trackmodel.hpp
M  +151  -0    tests/mixtest.cpp

https://invent.kde.org/multimedia/kdenlive/commit/b0be110a6bbf1a8731c4f01ffda6e370aa2a1ccc
Comment 3 Jean-Baptiste Mardelle 2022-06-02 06:46:34 UTC
Git commit d332064716d3ee9eaedaaf9402c9ffcd15a42de5 by Jean-Baptiste Mardelle.
Committed on 02/06/2022 at 06:19.
Pushed by mardelle into branch 'release/22.04'.

Fix slide composition going in wrong direction (mix is still todo)

M  +27   -1    src/timeline2/model/timelinemodel.cpp
M  +1    -0    src/timeline2/model/trackmodel.cpp
M  +32   -2    src/timeline2/view/timelinecontroller.cpp

https://invent.kde.org/multimedia/kdenlive/commit/d332064716d3ee9eaedaaf9402c9ffcd15a42de5
Comment 4 Jean-Baptiste Mardelle 2022-06-02 06:46:50 UTC
Git commit 019491631e59fc735fe1b3c7be33edea9314bed6 by Jean-Baptiste Mardelle.
Committed on 02/06/2022 at 06:19.
Pushed by mardelle into branch 'release/22.04'.

Fix Slide mix not correctly updated when creating a new mix on the previous clip, add tests.

M  +125  -22   src/timeline2/model/trackmodel.cpp
M  +4    -0    src/timeline2/model/trackmodel.hpp
M  +151  -0    tests/mixtest.cpp

https://invent.kde.org/multimedia/kdenlive/commit/019491631e59fc735fe1b3c7be33edea9314bed6
Comment 5 Guido 2022-06-02 09:10:51 UTC
Dear Jean-Baptiste,
I will try the appimage in the next few days and give you feedback.
In the meantime I want to thank you and all the kdenlive developers for not only fixing this bug, but for the amazing work you are doing. I have been using kdenlive for a very long time and have seen it grow. Each time I am amazed at how powerful and versatile it is. And knowing that annoying bugs like this are being fixed so quickly gives me a sense of confidence in the project.
So really thank you, you guys are great!
Comment 6 Guido 2022-06-04 18:48:03 UTC
I tested the last appimage, it works as expected.

Thank you!