Bug 453586 - No visual indicator that the Repeat Track button has a long-press menu
Summary: No visual indicator that the Repeat Track button has a long-press menu
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: 22.04.0
Platform: Flatpak Linux
: NOR minor
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-09 18:21 UTC by Jack Hill
Modified: 2022-05-10 16:46 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/multimedia/elisa/commit/8591836b31d04bfc21c9f7b2fdbaba7e8fcfa053
Version Fixed In: 22.08
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2022-05-09 18:21:34 UTC 
SUMMARY
There should probably be a little arrow on the button indicating that it has a long-press menu.

STEPS TO REPRODUCE
1. Press and hold Repeat Track button

OBSERVED RESULT
Menu opens

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20220506
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2022-05-10 15:40:05 UTC 
Were this a QtWidgets app, it would happen automatically. Because it's not, and the menu is custom, it's probably gonna be our responsibility to do it.
Comment 2 Nate Graham 2022-05-10 16:46:31 UTC 
Git commit 8591836b31d04bfc21c9f7b2fdbaba7e8fcfa053 by Nate Graham.
Committed on 10/05/2022 at 16:44.
Pushed by ngraham into branch 'master'.

Show a little arrow in the corner of the repeat button

This signifies that it will show a menu when pressed-and-held. Because
the button and its menu are custom, we're on the hook for drawing this
arrow, as we don't get it from the QStyle automatically.
FIXED-IN: 22.08

M  +11   -0    src/qml/MediaPlayerControl.qml

https://invent.kde.org/multimedia/elisa/commit/8591836b31d04bfc21c9f7b2fdbaba7e8fcfa053