Created attachment 148606 [details] Screenshot of the display rounding problem SUMMARY *** In the Unit module, if you input currency exchange rate with more than 2 decimals, it will save it in the system as what you input but after saved, it will round the exchange rate to the number of decimal configured in the system. Example: if you input exchange rate of EUR/USD as 1.0567 - it will save in the system 1.0567 and use that value for calculation - it will display the rate as 1.06 (following USD number of decimal) This is very misleading because the system actually saves the actual value you input but it's telling you it's saving something else. One way to confirm this is only a display problem: change the number of decimals for USD and EUR to 4 decimals, it will then show you what you input originally. But then all your values shows with 4 decimals everywhere, so that's not a solution *** STEPS TO REPRODUCE 1. Create 2 currencies in the system (EUR & USD) 2. Set the currency to 1.0567 and click "add" 3. Look at the data showing on the same screen, it will show 1.06 at 3 locations: - account listing - exchange rate listing - entry input field used to input the value OBSERVED RESULT The value is displayed rounded to the number of decimal of that currency EXPECTED RESULT The number of decimals should not matter when displaying exchange rate. So in that case we should always see the value with as many decimals as input by the user. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: Skrooge version: 2.27.0 ADDITIONAL INFORMATION
Changed assignee to myself. I submitted a Merge Request. Do let me know if the fix is correct (this is my first merge request).
Hi, Could you confirm that this request is closed ?
Hi Stephane, I added a PR but you rejected it quite a while back due to a side effect if we were to implement what I proposed: https://invent.kde.org/office/skrooge/-/merge_requests/17 So the problem is still there and it is very confusing for users (another topic partially related to this issue): https://forum.kde.org/viewtopic.php?f=210&t=174912 Though if there is no solutions for that and you prefer to close this bug if there is nothing we can do about it, please do so. No point keeping it open if it can't be solved.
Hi, I understand the issue and would like to propose you this: - The user is still able to enter more digits than digits displayed in operations, suboperations and units values. - This could cause some troubles. - I will add a new advice in dashboard to detect those cases and the user will be able to fix them automatically by rounding the values to the number of declared digit or to ignore the warning like for all other advice. Do you accept this proposal ?
Do you validate this proposal ?
Hi Stephane, The solution you propose might work to help users solve the display issue at the dashboard level but I don't think it's really solving the root cause. There are 2 problems related to number of decimals: 1 - Problem in Units module: - Users need to be able to input exchange rate with more than the 2 decimals display (for most currencies) - The system is actually already able to do that but since the display is following the number of decimals, nobody knows this - When you know it, it's somehow still a problem because when you want to see the past exchange rates you input in the system, you need to change the number of decimals to be able to see them correctly, then put it back to 2 when you are done. Whoever needs to use multi-currency in Skrooge will face this issue. For those first time testing Skrooge, it's a blocker. 2 - Problem in Operations: - In operations, unlike in Unit module, I am not sure if there is a valid scenario where users need to be able to input more decimals than what is configured in the system (but I am not an advanced user, I could be wrong). What is sure is that allowing the user to input more decimals than what is visible is source of problem, like what is happening in the dashboard. The solution you propose only tries to solve the problem #2. Since I am not sure if that use case should be allowed by skrooge, I don't know if your solution is okay or not. It doesn't feel right to me though. But the problem I am describing in this bug report is the problem #1 which is think is more important than problem #2 as it will impact more users and is really a blocker for those who need to deal with multi-currencies. Since the solutions I proposed last time is not acceptable due to technical reason (see my merge request: [https://invent.kde.org/office/skrooge/-/merge_requests/17]), I could propose another one (less nice but it would do the job): - Add another field to specify how many decimals you want to display for exchange rate - Display the exchange rate following that setting Let me know if this solution would be acceptable to you. Tks
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone!
*** This bug has been marked as a duplicate of bug 477688 ***