Created attachment 148449 [details] Note the orange arrow SUMMARY Because the close button in the Breeze decoration is not a circled X, but a single X by default, some icons about closing things in the icon theme should match. See attached image. As a side effect, applications using libadwaita (GTK 4) should gain consistency in their client-side decorations. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.93.0 Qt Version: 5.15.3 Kernel Version: 5.17.5-arch1-1 (64-bit) Graphics Platform: Wayland Processors: 12 × Intel® Core™ i5-10400 CPU @ 2.90GHz Memory: 15.5 GiB of RAM Graphics Processor: Mesa Intel® UHD Graphics 630
This would also affect the close icon in notifications.
> This would also affect the close icon in notifications. That's unrelated to the issue in GTK apps. *** This bug has been marked as a duplicate of bug 449876 ***
Artem, is there anything we can do here? Is this fixed by https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/56?
(In reply to Nate Graham from comment #3) > Artem, is there anything we can do here? Is this fixed by > https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/56? No, it fixes https://bugs.kde.org/show_bug.cgi?id=449876 for dialogs Technically this particular bug is a Breeze Icons issue which should provide correct default gtk icons. Libadwaita uses them and not our injections of KWin's decorations. So maybe this should be moved there.
Cool. What icon should be changed, and to what?
I suspect it's "window-close-symbolic"
Indeed, `window-close-symbolic` is circled. If we change that to just be an uncircled X, I wonder if it could have any other consequences...
Created attachment 149642 [details] kirigami(?) apps with a fake pop-up window using the "window-close-symbolic" icon. On mouse hover the "window-close" icon then appears. (In reply to Eduardo Alvarado from comment #1) > This would also affect the close icon in notifications. The close icon in notifications uses "window-close", not "window-close-symbolic". I have been investigating this for my 3rd party icons, and the only applications I have found so far which use "window-close-symbolic" are (I think) kirigami-based ones which have a fake pop-up window. See the attached screenshot. When you hover the close button with the mouse in these fake pop-up windows, they then show the "window-close" icon. (In reply to Nate Graham from comment #7) > Indeed, `window-close-symbolic` is circled. > > If we change that to just be an uncircled X, I wonder if it could have any > other consequences... An uncircled X would need to be larger than the current icon to match the other symbolic GTK CSD window icons. In the case of the kirigami(?) examples I mentioned above this would cause problems with the mouse-over of "window-close" being smaller. Either you could change the (also circled but red) "window-close" icon to be larger as well to match, or get the kirigami(?) apps to draw their own mouse-over highlight like GTK rather than using an icon. Overall, I like that Adwaita GTK now uses the "symbolic" icons for windows and I now use Adwaita GTK rather than Breeze GTK for that reason. It partially solves the regression in Wayland in bug 437082, and allows third party icon themes to now have at least some consistency.
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/211
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/212
Will be fixed with https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/349 now.
Git commit a22293658d0ec378bdf243781afbce5f26536a43 by Nate Graham. Committed on 04/01/2025 at 18:46. Pushed by ngraham into branch 'master'. Make the close icons be black X symbols Make the close icons be black X symbols Black is is a more correct color (closing windows and tabs isn't destructive, so it shouldn't use the red color), and omitting the circle makes it match the default window decoration icon and feel lighter and breezier. This implements what was decided in https://invent.kde.org/teams/vdg/issues/-/issues/62. FIXED-IN: 6.11 M +8 -11 icons/actions/16/window-close.svg M +12 -8 icons/actions/22/window-close.svg M +12 -8 icons/actions/32/window-close.svg https://invent.kde.org/frameworks/breeze-icons/-/commit/a22293658d0ec378bdf243781afbce5f26536a43