Created attachment 148435 [details] white to red gradient shows as blue to white on vectorscope. SUMMARY Vectorscope R and B channels are swapped. Graph shows wrong information. STEPS TO REPRODUCE (tested on windows10) 1. eg. Generate a red color clip, put on timeline. 2. open vectorscope from View > Vectorscope. 3. observe scope mark the red color as blue. (bug is limited to generated-color-clips, applies to all video files) OBSERVED RESULT Scope mark towards blue instead of red. EXPECTED RESULT Scope mark towards red. SOFTWARE/OS VERSIONS Windows: 10 pro ADDITIONAL INFORMATION
Created attachment 150079 [details] red-white-colorscope.png Wasn't able to repro this on Ubuntu 22.04 with Kdenlive 21.12.3 AppImage (screenshot attached). Vectorscope seems to show Red correctly.
Here is a step by step instruction how to see the issue: Bug 455053. Maybe a Windows (Mac) issue only?
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kdenlive/-/merge_requests/330
Git commit 3f8105070aeedcf09adba716f79639fc63f72f96 by Jean-Baptiste Mardelle, on behalf of Eric Jiang. Committed on 25/07/2022 at 11:13. Pushed by mardelle into branch 'master'. Change vectorscope to use QImage::pixel() Vectorscope tried to directly reinterpret the input QImage as RGB data, which makes an assumption that the input is RGB. On Windows, the input QImage is BGR, causing red and blue to be switched in the Vectorscope. QImage::pixel() checks QImageData->format and converts the to QRgb appropriately. Casual benchmarking seems to show that using pixel() is about 5% slower for each vectorscope calculation in the no-conversion case (e.g. Linux). M +13 -12 src/scopes/colorscopes/vectorscopegenerator.cpp https://invent.kde.org/multimedia/kdenlive/commit/3f8105070aeedcf09adba716f79639fc63f72f96
Git commit e0f68346d015180a0ccce2fd740bb3598f359a4a by Jean-Baptiste Mardelle, on behalf of Eric Jiang. Committed on 27/07/2022 at 11:47. Pushed by mardelle into branch 'release/22.08'. Change vectorscope to use QImage::pixel() Vectorscope tried to directly reinterpret the input QImage as RGB data, which makes an assumption that the input is RGB. On Windows, the input QImage is BGR, causing red and blue to be switched in the Vectorscope. QImage::pixel() checks QImageData->format and converts the to QRgb appropriately. Casual benchmarking seems to show that using pixel() is about 5% slower for each vectorscope calculation in the no-conversion case (e.g. Linux). M +13 -12 src/scopes/colorscopes/vectorscopegenerator.cpp https://invent.kde.org/multimedia/kdenlive/commit/e0f68346d015180a0ccce2fd740bb3598f359a4a