Bug 453054 - MYPAINT:Missing "dab per basic radius"
Summary: MYPAINT:Missing "dab per basic radius"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: 5.0.5
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: Tiar
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2022-04-26 14:50 UTC by thetwo
Modified: 2022-09-13 06:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
bug (66.07 KB, image/png)
2022-04-26 14:50 UTC, thetwo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description thetwo 2022-04-26 14:50:23 UTC
Created attachment 148387 [details]
bug

SUMMARY
Mypaint's "Dabs" has three parameters, while krita has only two. This means that we do not have full control over the spacing of the dabs. For example, I can't make a brush with scattered dabs. Similarly, I can't make scattered dabs close together.
This is a parameter in mypaint 1.0, and I think krita should add it.
Comment 1 Tiar 2022-08-10 17:54:37 UTC
How do those parameters differ? I think I can easily add it, but I'm not sure how to test if it's working correctly or not. Can you maybe give me two brushes where having those parameters swapped changes the brush significantly?
Comment 2 thetwo 2022-08-11 00:06:20 UTC
These three parameters are opposite to "space". The larger the value, the closer the DAB is. If they are all 0, the brush will not be able to draw.

Because three of them work at the same time, the other two need to be turned off during the test.

I think the difference between "basic radius" and "actual radius" is whether the radius changes. "Basic radius" should only refer to basic values.

https://ufile.io/e2lqh7px
I made the brushs and added the hue change. You can download it from the link above.
Comment 3 Bug Janitor Service 2022-08-16 20:16:03 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1545
Comment 4 Tiar 2022-09-08 07:50:16 UTC
Git commit 2c5fca39128376792c3ff3cafed3f0e27cdc375e by Agata Cacko.
Committed on 08/09/2022 at 01:32.
Pushed by dkazakov into branch 'master'.

Add Dabs Per Basic Radius to MyPaint brush editor

Before this commit, Dabs Per Basic Radius option was absent from
MyPaint brush editor in Krita despite it being in the libmypaint
that Krita uses. This commit adds it in the correct place.

M  +6    -0    plugins/paintops/mypaint/MyPaintPaintOpSettingsWidget.cpp

https://invent.kde.org/graphics/krita/commit/2c5fca39128376792c3ff3cafed3f0e27cdc375e
Comment 5 Tiar 2022-09-08 07:50:24 UTC
Git commit 5fdeef1ac36fe29322d59f31f59068f89f6fc5a5 by Agata Cacko.
Committed on 08/09/2022 at 01:32.
Pushed by dkazakov into branch 'master'.

Add Snap To Pixel to MyPaint brush editor

Before this commit, Snap To Pixel option was absent from
MyPaint brush editor in Krita despite it being in the libmypaint
that Krita uses. This commit adds it in the correct place.

The range should in theory be (0,1), but there are nice, random-like
textured results one can get when using Snap To Pixel with non-pixelated
brushes, so range 0-10 is useful.

To get the usual behaviour (for pixel art brushes), one should use value 1.0.

M  +7    -0    plugins/paintops/mypaint/MyPaintPaintOpSettingsWidget.cpp

https://invent.kde.org/graphics/krita/commit/5fdeef1ac36fe29322d59f31f59068f89f6fc5a5
Comment 6 Tiar 2022-09-08 07:50:32 UTC
Git commit 9f85d68d953c43beaebb43c40e23bed8d22cbd33 by Agata Cacko.
Committed on 08/09/2022 at 01:32.
Pushed by dkazakov into branch 'master'.

Add Pressure Gain Log to MyPaint brush editor

Before this commit, Pressure Gain Log option was absent from
MyPaint brush editor in Krita despite it being in the libmypaint
that Krita uses. This commit adds it in the correct place.

The range in libmypaint is -1.8 to 1.8, but values above 1.8 are still useful.
Hence the range in Krita is from -2 to 3.

Link:
https://github.com/mypaint/libmypaint/blame/master/brushsettings.json#L774

Default is 0.0.

M  +7    -0    plugins/paintops/mypaint/MyPaintPaintOpSettingsWidget.cpp

https://invent.kde.org/graphics/krita/commit/9f85d68d953c43beaebb43c40e23bed8d22cbd33
Comment 7 Tiar 2022-09-08 07:50:40 UTC
Git commit e652b38b435a0ea8c6cf46860296e2c325b229a9 by Agata Cacko.
Committed on 08/09/2022 at 01:32.
Pushed by dkazakov into branch 'master'.

Add Offset By Speed Filter option to MyPaint engine

iBefore this commit, Offset By Speed Filter option was absent from
MyPaint brush editor in Krita despite it being in the libmypaint
that Krita uses. This commit adds it in the correct place.

Note: this is dependant on Offset by Speed option.

Range and name (the internal one is `by Speed Slowness`, not `by Speed
Filter`) was taken from libmypaint.

M  +7    -0    plugins/paintops/mypaint/MyPaintPaintOpSettingsWidget.cpp

https://invent.kde.org/graphics/krita/commit/e652b38b435a0ea8c6cf46860296e2c325b229a9
Comment 8 Halla Rempt 2022-09-13 06:53:15 UTC
Git commit 36fa18a3489bbea928f361354cf283adce2f4c92 by Halla Rempt, on behalf of Agata Cacko.
Committed on 13/09/2022 at 06:52.
Pushed by rempt into branch 'krita/5.1'.

Add Dabs Per Basic Radius to MyPaint brush editor

Before this commit, Dabs Per Basic Radius option was absent from
MyPaint brush editor in Krita despite it being in the libmypaint
that Krita uses. This commit adds it in the correct place.
(cherry picked from commit 2c5fca39128376792c3ff3cafed3f0e27cdc375e)

M  +6    -0    plugins/paintops/mypaint/MyPaintPaintOpSettingsWidget.cpp

https://invent.kde.org/graphics/krita/commit/36fa18a3489bbea928f361354cf283adce2f4c92
Comment 9 Halla Rempt 2022-09-13 06:53:23 UTC
Git commit fd9955c093efc20b7a68f11ef5125150846f4c6d by Halla Rempt, on behalf of Agata Cacko.
Committed on 13/09/2022 at 06:52.
Pushed by rempt into branch 'krita/5.1'.

Add Snap To Pixel to MyPaint brush editor

Before this commit, Snap To Pixel option was absent from
MyPaint brush editor in Krita despite it being in the libmypaint
that Krita uses. This commit adds it in the correct place.

The range should in theory be (0,1), but there are nice, random-like
textured results one can get when using Snap To Pixel with non-pixelated
brushes, so range 0-10 is useful.

To get the usual behaviour (for pixel art brushes), one should use value 1.0.
(cherry picked from commit 5fdeef1ac36fe29322d59f31f59068f89f6fc5a5)

M  +7    -0    plugins/paintops/mypaint/MyPaintPaintOpSettingsWidget.cpp

https://invent.kde.org/graphics/krita/commit/fd9955c093efc20b7a68f11ef5125150846f4c6d
Comment 10 Halla Rempt 2022-09-13 06:53:32 UTC
Git commit 886392f63cd320367e703a9532a221bace5c61b0 by Halla Rempt, on behalf of Agata Cacko.
Committed on 13/09/2022 at 06:52.
Pushed by rempt into branch 'krita/5.1'.

Add Pressure Gain Log to MyPaint brush editor

Before this commit, Pressure Gain Log option was absent from
MyPaint brush editor in Krita despite it being in the libmypaint
that Krita uses. This commit adds it in the correct place.

The range in libmypaint is -1.8 to 1.8, but values above 1.8 are still useful.
Hence the range in Krita is from -2 to 3.

Link:
https://github.com/mypaint/libmypaint/blame/master/brushsettings.json#L774

Default is 0.0.
(cherry picked from commit 9f85d68d953c43beaebb43c40e23bed8d22cbd33)

M  +7    -0    plugins/paintops/mypaint/MyPaintPaintOpSettingsWidget.cpp

https://invent.kde.org/graphics/krita/commit/886392f63cd320367e703a9532a221bace5c61b0
Comment 11 Halla Rempt 2022-09-13 06:53:48 UTC
Git commit 8067ed5b1001db7d97a97d6ceddd926c407b99ae by Halla Rempt, on behalf of Agata Cacko.
Committed on 13/09/2022 at 06:52.
Pushed by rempt into branch 'krita/5.1'.

Add Offset By Speed Filter option to MyPaint engine

iBefore this commit, Offset By Speed Filter option was absent from
MyPaint brush editor in Krita despite it being in the libmypaint
that Krita uses. This commit adds it in the correct place.

Note: this is dependant on Offset by Speed option.

Range and name (the internal one is `by Speed Slowness`, not `by Speed
Filter`) was taken from libmypaint.
(cherry picked from commit e652b38b435a0ea8c6cf46860296e2c325b229a9)

M  +7    -0    plugins/paintops/mypaint/MyPaintPaintOpSettingsWidget.cpp

https://invent.kde.org/graphics/krita/commit/8067ed5b1001db7d97a97d6ceddd926c407b99ae