Bug 453046 - Line selection: The blueish selection background may start later in case of smaller preview icons
Summary: Line selection: The blueish selection background may start later in case of s...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: details mode (show other bugs)
Version: 22.04.0
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Travis Burrows
URL: https://invent.kde.org/system/dolphin...
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2022-04-26 12:04 UTC by postix
Modified: 2022-05-26 12:38 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (37.06 KB, image/png)
2022-04-26 12:04 UTC, postix
Details
Screenshot 2 (52.41 KB, image/png)
2022-04-26 12:06 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2022-04-26 12:04:44 UTC
Created attachment 148383 [details]
Screenshot

SUMMARY

Please see the screenshot.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20220424
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.2
Kernel Version: 5.17.4-1-default (64-bit)
Graphics Platform: Wayland
Comment 1 postix 2022-04-26 12:06:38 UTC
Created attachment 148384 [details]
Screenshot 2
Comment 2 Travis Burrows 2022-05-05 01:46:10 UTC
It appears that the logic determining the rectangle size is found here: https://invent.kde.org/system/dolphin/-/blob/master/src/kitemviews/kstandarditemlistwidget.cpp#L498.
Comment 3 Felix Ernst 2022-05-26 12:38:27 UTC
Git commit 58622f431b0d7d347333a4bc7b2f57fe17878f9d by Felix Ernst, on behalf of Travis Burrows.
Committed on 26/05/2022 at 12:38.
Pushed by felixernst into branch 'master'.

Extend selection rectangle to left edge

This commit changes it so the sizes of selection rectangles and hover
highlights in compact and details view mode is identical for all items.

Before this commit, selection rectangles in lists would have varying
indentation of the left edge of the selection rectangle depending on
the preview image's width-to-height ratio. This would cause a sort of
"ragged edge" in both compact and details list view when multiple items
were selected.

This commit doesn't change anything about icon view mode.

M  +10   -1    src/kitemviews/kstandarditemlistwidget.cpp

https://invent.kde.org/system/dolphin/commit/58622f431b0d7d347333a4bc7b2f57fe17878f9d