Bug 453024 - My smart patch tool is not working normally in 5.0.5 version. it can not cover the area i want like before.
Summary: My smart patch tool is not working normally in 5.0.5 version. it can not cove...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Smart Patch (show other bugs)
Version: 5.0.5
Platform: Android Linux
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-04-25 23:15 UTC by oaht tran
Modified: 2022-05-20 14:04 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
like this one, i dunno but 6 days ago, it was normal, and now, its not. (1.25 MB, image/jpeg)
2022-04-25 23:15 UTC, oaht tran
Details
Comparative examples of smart patch tool use (1.52 MB, application/zip)
2022-04-26 08:37 UTC, Ahab Greybeard
Details
smart patch tool (502.86 KB, image/jpeg)
2022-04-26 11:15 UTC, oaht tran
Details
when i use this tool (462.34 KB, image/jpeg)
2022-04-26 11:17 UTC, oaht tran
Details
compared the diffrent between before and after (475.14 KB, image/png)
2022-04-27 17:16 UTC, oaht tran
Details
this is result (2.21 MB, image/png)
2022-05-17 16:39 UTC, oaht tran
Details
infor (230.04 KB, image/jpeg)
2022-05-20 04:27 UTC, oaht tran
Details

Note You need to log in before you can comment on or make changes to this bug.
Description oaht tran 2022-04-25 23:15:26 UTC
Created attachment 148372 [details]
like this one, i dunno but 6 days ago, it was normal, and now, its not.

when i use this tool, its not cover by the exactly the same area, it cover by another one area
Comment 1 Michael Strothotte 2022-04-26 06:38:22 UTC
This error also shows up on Windows with the Krita portable and on Linux (SUSE Tumbleweed) with the AppImage of Krita. The behavior is very different to the behavior on Krita 4.4.8 where I was able to fix errors in a picture, the 5.0.5 is no longer able to fix these little errors in that picture. 

Regards
Michael Strothotte/Michelist
Comment 2 Ahab Greybeard 2022-04-26 08:37:42 UTC
Created attachment 148377 [details]
Comparative examples of smart patch tool use

This was first reported here:
https://krita-artists.org/t/smart-patch-tool-not-working/40236

I've attached some sample images showing the smart patch tool operation for versions 4.4.8, 5.0.2, 5.0.5 and the Apr 25 5.1.0-prealpha, all using the same parameters for the smart patch tool.
Comment 3 oaht tran 2022-04-26 11:15:48 UTC
Created attachment 148378 [details]
smart patch tool

yeah, 5.0.5 is not look like 5.0.2 version :( its still not working like it has to be
Comment 4 oaht tran 2022-04-26 11:17:48 UTC
Created attachment 148379 [details]
when i use this tool
Comment 5 oaht tran 2022-04-27 17:16:54 UTC
Created attachment 148417 [details]
compared the diffrent between before and after

i using tablet galaxy s7+ samsung
Krita 5.0.6, download on Chplay, beta version
smart patch tool cant cover the exactly the same area, so i have to using clone brush, but at this time, this brush cant work better on the dark background.
Comment 6 sh_zam 2022-04-28 12:27:08 UTC
This https://invent.kde.org/graphics/krita/-/commit/237e64119a1c54fc72a5c21d4a32a6ba40bf6875 seems to be the breaking commit.
Comment 7 Lynx3d 2022-05-17 15:24:54 UTC
Commit https://invent.kde.org/graphics/krita/-/commit/1d84308df8d96c5b657626920395e22eefc718af
should resolve the issue.
Comment 8 oaht tran 2022-05-17 16:38:23 UTC
(In reply to Lynx3d from comment #7)
> Commit
> https://invent.kde.org/graphics/krita/-/commit/
> 1d84308df8d96c5b657626920395e22eefc718af
> should resolve the issue.

 my image is a "normal" image, the first i was use is 8-bit but now, when i try 32-bit channel, its still not working like it was.
i make sure that i was follow 3 steps in that link. but with my image (manga) it still not working. However, its better. 
Thank you so much, it really solve my issue, maybe because i use thr raw of manga- many patterns. 
Krita 5.0.6, Samsung tab s7+.
Comment 9 oaht tran 2022-05-17 16:39:29 UTC
Created attachment 148921 [details]
this is result
Comment 10 oaht tran 2022-05-19 09:58:44 UTC
i dunno but, this tool is still broken, i have check on my pc, my tablet, but they still broken at all. 32-bit for all picture but cannot work like before:(
Comment 11 Lynx3d 2022-05-19 16:45:42 UTC
Please be more precise about which build you tested, because on a quick test it works fine for me with 32-bit float.
You mentioned 5.0.6 but that can't get the fix anymore of course.

Assuming we're still talking about Android, make sure you try the nightly build #723 (May 18) or later.
Comment 12 oaht tran 2022-05-20 04:24:04 UTC
version 5.0.6 
but the lastest update is 26/04/2022
RGB/Alpha, 32-bit float/channel, sGRB-elle-V2-g10.icc. 
iam sorry, maybe because my picture of the result is not clearly:(
Comment 13 oaht tran 2022-05-20 04:27:09 UTC
Created attachment 149013 [details]
infor

version 5.0.6
update: 27.04.2022
and did not have any notice that will have another fix of new version
Comment 14 oaht tran 2022-05-20 04:29:25 UTC
(In reply to Lynx3d from comment #11)
> Please be more precise about which build you tested, because on a quick test
> it works fine for me with 32-bit float.
> You mentioned 5.0.6 but that can't get the fix anymore of course.
> 
> Assuming we're still talking about Android, make sure you try the nightly
> build #723 (May 18) or later.

sorry but i do not understand clearly what is the build #723? The fix of bug or new version? 
thank you!
Comment 15 sh_zam 2022-05-20 11:01:28 UTC
(In reply to oaht tran from comment #14)
> sorry but i do not understand clearly what is the build #723? The fix of bug
> or new version? 
> thank you!

It is the build number of a nightly build. You can get the APK from our nightly builder from here: https://binary-factory.kde.org/job/Krita_Nightly_Android_arm64-v8a_Build/
Comment 16 oaht tran 2022-05-20 14:04:13 UTC
(In reply to sh_zam from comment #15)
> (In reply to oaht tran from comment #14)
> > sorry but i do not understand clearly what is the build #723? The fix of bug
> > or new version? 
> > thank you!
> 
> It is the build number of a nightly build. You can get the APK from our
> nightly builder from here:
> https://binary-factory.kde.org/job/Krita_Nightly_Android_arm64-v8a_Build/

thank you so much <3