Bug 452946 - Can only get the last 10 messages of any conversation
Summary: Can only get the last 10 messages of any conversation
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: messaging-application (other bugs)
Version First Reported In: 22.04.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Simon Redman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-24 11:11 UTC by Nathan
Modified: 2023-02-05 03:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2022-04-24 11:11:57 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
Opening any conversation will only show the last 10 messages maximum. I would expect to be able to see the whole conversation

STEPS TO REPRODUCE
1. Open KDE Connect SMS
2. Open any conversation
3. 

OBSERVED RESULT
I only get the last 10 messages

EXPECTED RESULT
I would expect to be able to see the whole conversation and if its too large, load more as you scroll down.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Fedora Linux 35
(available in About System)
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Journalctl -r output :-

kdeconnect-sms[2160]: qrc:/qml/MessageAttachments.qml:136:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
kdeconnect-sms[2160]: qrc:/qml/MessageAttachments.qml:136:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
kdeconnect-sms[2160]: file:///usr/lib64/qt5/qml/org/kde/kirigami.2/private/globaltoolbar/ToolBarPageHeader.qml:38:13: Unable to assign [undefined] to bool
kdeconnect-sms[2160]: file:///usr/lib64/qt5/qml/org/kde/kirigami.2/private/globaltoolbar/ToolBarPageHeader.qml:39:13: Unable to assign [undefined] to double
kdeconnect-sms[2160]: file:///usr/lib64/qt5/qml/org/kde/kirigami.2/private/globaltoolbar/ToolBarPageHeader.qml:40:13: Unable to assign [undefined] to double
kdeconnect-sms[2160]: file:///usr/lib64/qt5/qml/org/kde/kirigami.2/private/globaltoolbar/ToolBarPageHeader.qml:41:13: Unable to assign [undefined] to double
kdeconnect-sms[2160]: qrc:/qml/SendingArea.qml:69:17: QML TextArea: Possible anchor loop detected on fill.
kdeconnect-sms[2160]: qrc:/qml/ChatMessage.qml:109: TypeError: Value is undefined and could not be converted to an object
kdeconnectd[1627]: QMetaObject::invokeMethod: No such method KIO::StoredTransferJob::slotDataReqFromDevice()
Comment 1 Simon Redman 2022-05-21 01:30:54 UTC
Hi Nathan,

Thanks for reporting this. Sorry for the delay in responding (thanks you to whomever just caused this to get bumped in my email!)

I have the same issue on Fedora with my non-RPM build. It makes me strongly suspect a bump in some dependency as the culprit. I noticed other things broke at the same time, for instance MMS messages appear as single-target messages.

As for scrolling, your expected behavior is how it used to behave. If you click your mouse on the background, are you able to "flick" to scroll up and down? That works for me.

I have spent several hours debugging this and unfortunately have come up blank so far. I'm likely not going to be able to devote much time to it for awhile. If someone would like to help out, please simply downgrade dependencies (Qt Quick Controls 2, kf5-kirigami, etc.) and see if you are able to get the issue to go away.
Comment 2 Nathan 2022-05-21 01:58:12 UTC
Hi Simon,
Thanks for your reply.
I have upgraded to Fedora 36 with kdeconnect at version 22.04.1 and issue is still present. The conversation window does scroll but only between the 10 messages that it loads.

Operating System: Fedora Linux 36
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.3
Kernel Version: 5.17.8-300.fc36.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-8565U CPU @ 1.80GHz
Memory: 15.4 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620
Comment 3 Simon Redman 2023-01-22 22:10:52 UTC
Git commit 5b716dde02a3cc533ab73b10e96fccd37905b639 by Simon Redman.
Committed on 22/01/2023 at 22:10.
Pushed by sredman into branch 'master'.

[SMS App] Fix loading more messages

## Summary

For awhile (since at least early last year), it has not been possible to scroll past the first screen of message history. I believe this was due to a version bump in some library, but I was not able to biset it at the time.

This changes how messages are loaded to work again. I like this solution better anyway, because it means one can smoothly scroll back in time without needing to stop every time you reach the top of the history.

## Test Plan

### Before:
Scrolling to the top of the kdeconnect-sms history would do nothing. You could only view the first handful of messages in the conversation (whichever messages the app decided to load for you when you first open the conversation).

### After:
Scrolling to the top of the list of messages will cause the app to load more, allowing you to view more history of messages.

M  +16   -5    smsapp/qml/ConversationDisplay.qml

https://invent.kde.org/network/kdeconnect-kde/commit/5b716dde02a3cc533ab73b10e96fccd37905b639
Comment 4 Simon Redman 2023-01-22 22:11:36 UTC
Git commit 66a355076c39170047735a5a5bdb45bd25bf70ce by Simon Redman.
Committed on 22/01/2023 at 22:11.
Pushed by sredman into branch 'release/22.12'.

[SMS App] Fix loading more messages

## Summary

For awhile (since at least early last year), it has not been possible to scroll past the first screen of message history. I believe this was due to a version bump in some library, but I was not able to biset it at the time.

This changes how messages are loaded to work again. I like this solution better anyway, because it means one can smoothly scroll back in time without needing to stop every time you reach the top of the history.

## Test Plan

### Before:
Scrolling to the top of the kdeconnect-sms history would do nothing. You could only view the first handful of messages in the conversation (whichever messages the app decided to load for you when you first open the conversation).

### After:
Scrolling to the top of the list of messages will cause the app to load more, allowing you to view more history of messages.


(cherry picked from commit 5b716dde02a3cc533ab73b10e96fccd37905b639)

M  +16   -5    smsapp/qml/ConversationDisplay.qml

https://invent.kde.org/network/kdeconnect-kde/commit/66a355076c39170047735a5a5bdb45bd25bf70ce
Comment 5 Nathan 2023-01-23 04:23:13 UTC
Awesome I look forward to trying it. Thanks for your work :-)
Comment 6 Nathan 2023-02-05 03:17:44 UTC
Works great thank you so much :-)