Bug 452901 - UI: Tab focus order is a bit broken on the Printer page
Summary: UI: Tab focus order is a bit broken on the Printer page
Status: RESOLVED FIXED
Alias: None
Product: print-manager
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Daniel Nicoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-23 10:14 UTC by ratijas
Modified: 2023-08-22 15:47 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/utilities/print-manager/-/commit/557185512e0c054bedc01ced84ab4153c2041cb7
Version Fixed In:
Sentry Crash Report:

Attachments
Printer KCM - Tab order (188.59 KB, video/mp4)
2022-04-23 10:14 UTC, ratijas 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description ratijas 2022-04-23 10:14:09 UTC 
Created attachment 148318 [details]
Printer KCM - Tab order

SUMMARY
Action buttons are laid out vertically in the following order:

Maintenance ▾
Configure
Open Print Queue

But when tabbing throught the page, the Configure button gets focus before the «Maintenance ▾»; and also there's an invisible(?) element getting focused between «System Preferences ▾» drop-down and the set of checkboxes.

STEPS TO REPRODUCE
1. Connect/Add a printer.
2. Open Printers KCM (System Settings page).
3. Press Tab repeatedly.

OBSERVED RESULT
The order in which elements are getting focused is wrong.

EXPECTED RESULT
Top-to-bottom order, no invisible or non-actionable focused elements.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.3
Kernel Version: 5.17.4-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz
Memory: 15.6 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 970M/PCIe/SSE2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2023-08-22 15:47:03 UTC 
Git commit 557185512e0c054bedc01ced84ab4153c2041cb7 by Nate Graham, on behalf of Mike Noe.
Committed on 22/08/2023 at 17:47.
Pushed by ngraham into branch 'kf6'.

kcm: Port to QML

- Follow-on to utilities/print-manager!21
- Rename the qml files to use more standarg naming conventions
- Use the new kcmutils tooling

Co-authored-by: Nicolas Fella <nicolas.fella@gmx.de>
Related: bug 451275

M  +2    -0    .kde-ci.yml
M  +27   -4    CMakeLists.txt
M  +1    -1    src/CMakeLists.txt
A  +12   -0    src/kcm/CMakeLists.txt
A  +3    -0    src/kcm/Messages.sh
R  +0    -0    src/kcm/kcm_printer_manager.json [from: src/printer-manager-kcm/kcm_printer_manager.json - 100% similarity]
A  +254  -0    src/kcm/printermanager.cpp     [License: GPL(v2.0+)]
A  +75   -0    src/kcm/printermanager.h     [License: GPL(v2.0+)]
A  +51   -0    src/kcm/ui/Global.qml     [License: GPL(v2.0+)]
A  +177  -0    src/kcm/ui/PrinterSettings.qml     [License: GPL(v2.0+)]
A  +119  -0    src/kcm/ui/main.qml     [License: GPL(v2.0+)]
M  +1    -1    src/libkcups/PrinterModel.cpp
D  +0    -28   src/printer-manager-kcm/CMakeLists.txt
D  +0    -389  src/printer-manager-kcm/PrintKCM.cpp
D  +0    -63   src/printer-manager-kcm/PrintKCM.h
D  +0    -266  src/printer-manager-kcm/PrintKCM.ui
D  +0    -127  src/printer-manager-kcm/PrinterDelegate.cpp
D  +0    -38   src/printer-manager-kcm/PrinterDelegate.h
D  +0    -257  src/printer-manager-kcm/PrinterDescription.cpp
D  +0    -71   src/printer-manager-kcm/PrinterDescription.h
D  +0    -315  src/printer-manager-kcm/PrinterDescription.ui

https://invent.kde.org/utilities/print-manager/-/commit/557185512e0c054bedc01ced84ab4153c2041cb7