Bug 452899 - Preview and action buttons may overlap
Summary: Preview and action buttons may overlap
Status: RESOLVED INTENTIONAL
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-23 09:31 UTC by ratijas
Modified: 2022-04-26 13:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Overlapping Spectacle notification (62.13 KB, image/png)
2022-04-23 09:31 UTC, ratijas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ratijas 2022-04-23 09:31:09 UTC
Created attachment 148316 [details]
Overlapping Spectacle notification

SUMMARY
Layout of notifications with both preview content and action buttons isn't very adaptive.

STEPS TO REPRODUCE
1. Take a screenshot via spectacle shortcut
2. See the notification with an embedded preview and two action buttons

OBSERVED RESULT
Preview and buttons overlap a few pixels. With different screenshot size ratio and language the overlap may be much bigger.

EXPECTED RESULT
They should not overlap. For example, buttons could push the preview to the left (if they all are in a single row layout) etc.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.3
Kernel Version: 5.17.4-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz
Memory: 15.6 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 970M/PCIe/SSE2
Comment 1 Nate Graham 2022-04-25 18:18:35 UTC
We used to have the buttons on their own row, but people complained that it was a waste of space and looked ugly. Ultimately we have to choose to either do that or else overlap content with certain content/language combinations, and we eventually settled on the latter. I think it's the best we can do here.
Comment 2 ratijas 2022-04-26 09:26:46 UTC
Sounds like it should be adaptive. Inline if they fit, or an extra row when they don't. What do you think?
Comment 3 Nate Graham 2022-04-26 13:42:10 UTC
I dunno, then the UI layout would seem random. I doubt users would recognize the positioning pattern for such an infrequently-used transient UI element.
Comment 4 ratijas 2022-04-26 13:46:37 UTC
Android somehow manages it pretty much alright. They even sometimes have two rows of buttons in notifications: actions (Mark as Read, Reply, Delete, etc.) and quick replies (some dark magic, probably auto-generated by text analyzing AI) like "OK", "Good", "Later", "Really?" etc.