Bug 452523 - Don't flash the "Settings" header on CategorizedSettings when a side-panel item is clicked
Summary: Don't flash the "Settings" header on CategorizedSettings when a side-panel it...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.92.0
Platform: Other Linux
: NOR minor
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-11 22:25 UTC by Jack Hill
Modified: 2022-11-23 13:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2022-04-11 22:25:32 UTC
SUMMARY
Clicking on an category in the CategorizedSettings side-panel causes the header to flash. This is because clicking on the side-panel makes the Settings page take focus, and releasing the mouse button gives focus to the category page.

Also, there's no point in "Settings" being clickable when the side-panel is visible since clicking it appears to do nothing. (I expected it to take me to some sort of Settings home page, like in system settings, and was confused when it didn't do anything.)

STEPS TO REPRODUCE
1. Open Kalendar or NeoChat
2. Open settings
3. Make sure the settings window is wide enough for a side-panel
4. Click a side-panel category

OBSERVED RESULT
The header flashes.

EXPECTED RESULT
The header should not flash.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20220409
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Jack Hill 2022-11-23 13:10:32 UTC
Looks like it was solved by just hiding the header bar on desktop

https://invent.kde.org/frameworks/kirigami/-/commit/c95c71e597e9807833b72aa0bd0a57cfd05d4d6e