Bug 452122 - Missing download support based on QtNetwork
Summary: Missing download support based on QtNetwork
Status: RESOLVED FIXED
Alias: None
Product: libalkimia
Classification: Unclassified
Component: General (show other bugs)
Version: 8.1.0
Platform: Other Microsoft Windows
: NOR wishlist
Target Milestone: 8.1
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-31 17:57 UTC by Ralf Habacker
Modified: 2022-03-31 21:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 8.1.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2022-03-31 17:57:52 UTC
SUMMARY

The alkimia library currently uses the KIO framework for downloading native online content from remote sites. The disadvantage of this support is higher complexity in the installed application, as additional background programs are required for this (klauncher.exe, kioslave.exe). This increases the susceptibility to errors and the required maintenance effort. As a simpler alternative, the network support of the QtNetwork library can be used for these purposes.

STEPS TO REPRODUCE
1. download an alkimia package from https://binary-factory.kde.org or https://kmymoney.org/snapshots.php  
2. start onlinequoteseditor and fetch online quotes 
3. inspect the running background processes

OBSERVED RESULT
There are additional processes like klauncher.exe and one or more kioslave.exe

EXPECTED RESULT
When using QtNetwork's http(s) download support, these processes are not required 

SOFTWARE/OS VERSIONS
Windows: 10 
KDE Frameworks Version: 5.x 
Qt Version: 5.x
Comment 1 Ralf Habacker 2022-03-31 21:57:45 UTC
Git commit a37b285a2d20faf383a55f46e9ec540f8cffd370 by Ralf Habacker.
Committed on 31/03/2022 at 21:57.
Pushed by habacker into branch '8.1'.

Added support for using QtNetwork to download online quotes

To enable the mentioned support, a new cmake variable
BUILD_WITH_QTNETWORK has been added.

When the mentioned cmake variable is set to 1 or ON, which is
default on Windows, AlkOnlineQuotes::launchNative() uses Qt
network support for downloading data. If it is set to 0 or
OFF, the KIO library support is used, which is the default on
non Windows platforms.

The advantage of using Qt network support is less dependency
on 3rd party components, thus less error-proneness and
higher speed on Windows.
FIXED-IN:8.1.1

M  +27   -4    CMakeLists.txt
M  +4    -3    README.md
M  +1    -1    autotests/CMakeLists.txt
M  +4    -3    src/CMakeLists.txt
M  +7    -2    src/LibAlkimiaConfig.cmake.in
M  +70   -11   src/alkonlinequote.cpp
M  +1    -1    tests/CMakeLists.txt
M  +0    -2    tools/onlinequoteseditor/CMakeLists.txt

https://invent.kde.org/office/alkimia/commit/a37b285a2d20faf383a55f46e9ec540f8cffd370