Bug 451573 - Okular setting Accessibility - Change dark and light colors - should be renamed to 'Change text and background colors'
Summary: Okular setting Accessibility - Change dark and light colors - should be renam...
Status: RESOLVED NOT A BUG
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 22.08.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-16 14:42 UTC by cipricus
Modified: 2022-10-26 12:10 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Settings - Configure Okular - Accessibility - Change colors - 'Change dark and light colors' (87.50 KB, image/png)
2022-03-16 14:42 UTC, cipricus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cipricus 2022-03-16 14:42:08 UTC
Created attachment 147527 [details]
Settings - Configure Okular - Accessibility - Change colors - 'Change dark and light colors'

Settings - Configure Okular - Accessibility - Change colors - 'Change dark and light colors' is an excellent option to display text in full yet adjustable dark mode.

But the way the options are named is confusing, because it makes little sense saying "dark" or "light" when any color can be set there. In fact under "dark color" it's the font (foreground) color setting - the one under "light color" it's the background color. 
And that's how they should be called.
Comment 1 cipricus 2022-03-16 14:51:00 UTC
So, instead of :

* "Change dark and light colors"   >    "Change foreground and background colors"
* "Dark color"                                    >    "Foreground color"
* "Light color"                                   >    "Background color"
Comment 2 Bug Janitor Service 2022-03-17 07:57:10 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/587
Comment 3 cipricus 2022-03-18 09:58:58 UTC
(In reply to Bug Janitor Service from comment #2)
> A possibly relevant merge request was started @
> https://invent.kde.org/graphics/okular/-/merge_requests/587

I have changed my mind after seeing reply by  @davidhurka (https://invent.kde.org/graphics/okular/-/merge_requests/587#note_416624). I now think that the present terminology is preferable to the one mentioned in this bug report and that a change could be proposed in favor of "black" and "white'. My argument is here: https://invent.kde.org/graphics/okular/-/merge_requests/587#note_417031
Comment 4 cipricus 2022-03-18 10:00:30 UTC
I think this is not the case, and should be closed. I have argued here: https://invent.kde.org/graphics/okular/-/merge_requests/587#note_417031
Comment 5 cipricus 2022-10-26 11:29:50 UTC
I am changing my mind back - the settings should be called "background" and "text" - based on new arguments, detailed here: 

https://www.reddit.com/r/kde/comments/ydv4g7/comment/itubc9q/?utm_source=share&utm_medium=web2x&context=3
https://www.reddit.com/r/kde/comments/ydqsvc/comment/itubuzf/?utm_source=share&utm_medium=web2x&context=3

In fact this is related to the fact whether images should be affected by color change or not. it seems obvious to me that thay should not, as asked here: https://www.reddit.com/r/kde/comments/ydqsvc/okular_invert_colors_but_not_for_images/?utm_source=share&utm_medium=web2x&context=3

The  contrary argument (namely: that the background can be light or dark) makes sense only for images. But if images should not be affected by color change then the color change settings are really only about background and foreground=text.
Comment 6 cipricus 2022-10-26 12:09:47 UTC
There is a case where images should be affected by color change: when these images are images of text, where again "background color" and "text color" would be useful terminology.