Bug 451301 - Kate crashes when opening a file while save file dialog is open
Summary: Kate crashes when opening a file while save file dialog is open
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: 5.27.0
Platform: Arch Linux Linux
: NOR crash
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-09 03:39 UTC by tux
Modified: 2024-06-28 03:47 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tux 2022-03-09 03:39:59 UTC
STEPS TO REPRODUCE
1. Open Kate and click "File → Save As..."
2. Don't save the file, but leave the dialog window open
3. With the window open, click "File → Open..." and open any file
4. Kate crashes

Operating System: Arch Linux
KDE Plasma Version: 5.24.3
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Kernel Version: 5.16.12-arch1-1 (64-bit)
Graphics Platform: Wayland
Comment 1 Christoph Cullmann 2022-03-13 20:42:06 UTC
Hmm, the Save As... dialog should be modal, I am not able to click File -> Open... at all.
Comment 2 tux 2022-03-13 21:55:02 UTC
(In reply to Christoph Cullmann from comment #1)
> Hmm, the Save As... dialog should be modal, I am not able to click File ->
> Open... at all.

Oh, yeah, I used the Application menu in the Titlebar (customizable via System Settings → Appearance → Window Decorations → Titlebar Buttons). Regardless, I think Kate should still not crash. Kwrite doesn't crash when doing the same.
Comment 3 Christoph Cullmann 2022-03-13 22:17:56 UTC
Have you some backtrace for the crash?
Comment 4 tux 2022-03-13 22:19:13 UTC
(In reply to Christoph Cullmann from comment #3)
> Have you some backtrace for the crash?

No, but if you put the Application menu in the Titlebar through System Settings, you'll probably get the same behavior.
Comment 5 carlos 2022-03-14 21:41:14 UTC
Not reproducable in master branch
Comment 6 Christoph Cullmann 2022-04-07 19:46:51 UTC
Yeah, ok, crashes, but that is really evil, that kills the total modal dialog concept...
Comment 7 Ahmad Samir 2022-04-09 13:10:38 UTC
This looks like an issue with the dbusmenu/appmenu stuff in Plamsa-workspace/KWin, while an app has a modal dialog open, there should ideally be a way to block the AppMenu stuff from being used, otherwise we end up with these unexpected situations.
Comment 8 Christoph Cullmann 2022-04-09 14:42:10 UTC
Yes, I don't think that is actually properly fixable on the application side.

In this case here, the view that has the other modal dialog open will be deleted after the open dialog exits.

There is no sane way to avoid this crash in KTextEditor or Kate/KWrite.
Comment 9 tux 2022-04-09 14:51:50 UTC
(In reply to Christoph Cullmann from comment #8)
> There is no sane way to avoid this crash in KTextEditor or Kate/KWrite.

Like I said earlier, KWrite does not crash when doing the same.
Comment 10 Christoph Cullmann 2022-04-09 15:01:50 UTC
(In reply to wokim from comment #9)
> (In reply to Christoph Cullmann from comment #8)
> > There is no sane way to avoid this crash in KTextEditor or Kate/KWrite.
> 
> Like I said earlier, KWrite does not crash when doing the same.

That is sadly no longer true, as KWrite shares now the same code as Kate in master.

That KWrite didn't crash before was sheer luck that there the handling of open is differently.

That modal dialogs are no longer modal with this feature is the real issue, the application relies on that, otherwise these dialogs wouldn't be modal in the first place.
Comment 11 David Edmundson 2024-05-29 10:32:24 UTC
This bug is a crash report that is over a year old without any activity, as our software is always changing, the information in this ticket is unlikely to still be useful.

If this issue is still reproducible in a newer version of kwin (5.27.5 or 6.0) please reopen this ticket with a bumped version number or it will be closed in 30 days.
Comment 12 tux 2024-05-29 14:31:03 UTC
(In reply to David Edmundson from comment #11)
> This bug is a crash report that is over a year old without any activity, as
> our software is always changing, the information in this ticket is unlikely
> to still be useful.
> 
> If this issue is still reproducible in a newer version of kwin (5.27.5 or
> 6.0) please reopen this ticket with a bumped version number or it will be
> closed in 30 days.

The crash does not seem to happen anymore with kwin 6.0 (wayland) on my system.
Comment 13 Bug Janitor Service 2024-06-13 03:46:54 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 14 Bug Janitor Service 2024-06-28 03:47:49 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!