Bug 451145 - Icon alignment method is inconsistent
Summary: Icon alignment method is inconsistent
Status: RESOLVED UPSTREAM
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 21.12.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-04 22:57 UTC by doncbugs
Modified: 2022-04-05 00:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
The tab icons on the right are higher than those under "Places" (4.46 KB, image/png)
2022-03-04 22:57 UTC, doncbugs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description doncbugs 2022-03-04 22:57:29 UTC
Created attachment 147284 [details]
The tab icons on the right are higher than those under "Places"

SUMMARY

While making an icon theme I noticed that the way icons are aligned with text in tabs is different from how they are aligned in the places pane. This results in an odd effect where icons in the tabs are 'floating away'.


STEPS TO REPRODUCE
1. Open Places pane and select 16px icons
2. Open more than one tab

OBSERVED RESULT
Tab icons are higher than Places entry icons, relative to the text.

EXPECTED RESULT
The alignment of the icons with text should be consistent.
Comment 1 Nate Graham 2022-03-25 03:26:32 UTC
We are simply using the icon functionality of the QTabBar component, so this would be an upstream issue in Qt. Could you report it to them at https://bugreports.qt.io/? Thanks!
Comment 2 doncbugs 2022-03-25 07:00:25 UTC
(In reply to Nate Graham from comment #1)
> We are simply using the icon functionality of the QTabBar component, so this
> would be an upstream issue in Qt. Could you report it to them at
> https://bugreports.qt.io/? Thanks!

Seems like it already was. Is there any reason why ours would not be centered or is this a regression?

https://bugreports.qt.io/browse/QTBUG-38108
Comment 3 Nate Graham 2022-03-31 19:10:17 UTC
Could be a regression, yeah.
Comment 4 doncbugs 2022-04-05 00:31:40 UTC
(In reply to Nate Graham from comment #3)
> Could be a regression, yeah.

It has been reported here: https://bugreports.qt.io/browse/QTBUG-38108