Bug 451105 - UI regression when mounting LUKS-encrypted disks caused by 5d2b5180fc4d1737f12cbbaba12884dbae832823
Summary: UI regression when mounting LUKS-encrypted disks caused by 5d2b5180fc4d1737f1...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-solid
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Lukáš Tinkl
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-03-03 20:23 UTC by Nate Graham
Modified: 2022-03-04 21:37 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Nasty error message (201.90 KB, image/png)
2022-03-03 20:23 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-03-03 20:23:46 UTC
Created attachment 147266 [details]
Nasty error message

After 5d2b5180fc4d1737f12cbbaba12884dbae832823 (confirmed with git bisect), unlocking LUKS devices suffers from a poor UI:  when you try a "mount and open" from either the Disks & Devices applet or Dolphin's sidebar, you are asked for a password, but after you enter it, a nasty error message is seen. See attachment.

The encrypted volume is indeed mounted and shows up in the "Devices" section of the Places panel, but does not appear as such in the "Removable Devices" section of the Places panel or the Disks & Devices applet. Instead, it shows up as locked and unmounted there; if you click on it, it asks you the password to unlock again. If you enter it, you will see a new error message explaining that it is already unlocked. This is weird and confusing and will probably trick people into thinking their data is inaccessible, which happened to me when I first encountered the problem, causing a few minutes of panic.
Comment 1 Méven Car 2022-03-04 08:08:59 UTC
Let's revert 5d2b5180fc4d1737f12cbbaba12884dbae832823
Comment 2 Nate Graham 2022-03-04 21:37:13 UTC
Git commit 1d7cceda76bd3a1c2c4060d7c215ff6cbae64769 by Nate Graham.
Committed on 04/03/2022 at 18:50.
Pushed by ngraham into branch 'master'.

Revert "Don’t create a full Solid::Device to check encryption"

This reverts commit 5d2b5180fc4d1737f12cbbaba12884dbae832823.

This commit regressed mounting LUKS volumes; we will have to find a
better way.
Related: bug 398908

M  +2    -3    src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

https://invent.kde.org/frameworks/solid/commit/1d7cceda76bd3a1c2c4060d7c215ff6cbae64769