Bug 450963 - Only unfocused desktop thumbnails show the panel
Summary: Only unfocused desktop thumbnails show the panel
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-overview (show other bugs)
Version: 5.24.2
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-28 13:20 UTC by Michael D
Modified: 2023-01-09 16:30 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27
Sentry Crash Report:


Attachments
The panel on the right is not visible on focused desktop thumbnail (24.65 KB, image/png)
2022-03-21 08:31 UTC, Michael D
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2022-02-28 13:20:44 UTC
If you squint at the unfocused desktop thumbnails, you can see the panel which is not visible on the focused one.
Comment 1 Nate Graham 2022-03-21 03:53:14 UTC
I see my panel on all desktop thumbnails and I was under the impression that this was expected. Can you attach a screenshot that clearly shows the issue?
Comment 2 Michael D 2022-03-21 08:29:51 UTC
I have my panel on the right, which may make a difference. Attached is a screenshot.
Comment 3 Michael D 2022-03-21 08:31:00 UTC
Created attachment 147646 [details]
The panel on the right is not visible on focused desktop thumbnail
Comment 4 Nate Graham 2022-03-23 21:51:42 UTC
Ah! I see the issue. The focus outline is drawn inside the thumbnail rather than outside of it, so it completely covers skinny panels. Should be an easy fix.
Comment 5 Michael D 2022-03-23 21:53:33 UTC
Ah, is that what's going on? The panel is 40px wide, so not exactly skinny, but the outline should definitely be drawn around the thumbnail.
Comment 6 Niklas Stephanblome 2023-01-08 21:35:03 UTC
I made a merge request that fixes the issue. I will close this bug report as soon as it gets merged. https://invent.kde.org/plasma/kwin/-/merge_requests/3408
Comment 7 Nate Graham 2023-01-08 23:30:23 UTC
It'll happen automatically once the MR is merged if you add "BUG: 450963` to its own line in the MR description. See https://community.kde.org/Infrastructure/GitLab#Write_a_Good_Commit_Message.
Comment 8 Nate Graham 2023-01-09 16:30:00 UTC
Git commit 1f1e67f90be39460bd7f087c0c538545a092ccc1 by Nate Graham, on behalf of Niklas Stephanblome.
Committed on 09/01/2023 at 16:29.
Pushed by ngraham into branch 'master'.

effects/overview: Correct size of active virtual desktop highlight outline

The focus outline that highlights the active virtual desktop in the Overview effect, as
well as the half-transparent outlines that are around the other virtual desktops, cover
2 pixels on every side of every virtual desktop thumbnail.

This is because an invisible rectangle is used that has the same size as the thumbnail
and has a colored border, but borders are always drawn on the inside of QML rectangles,
so content in the thumbnail is covered up. Therefore, the width of the rectangle has to
be slightly adjusted to account for the thickness of the border.
FIXED-IN: 5.27

M  +1    -0    src/effects/overview/qml/DesktopBar.qml

https://invent.kde.org/plasma/kwin/commit/1f1e67f90be39460bd7f087c0c538545a092ccc1