Bug 450870 - Zoom icons in FreeCAD toolbar fall back to `zoom` due to lack of more specific icons
Summary: Zoom icons in FreeCAD toolbar fall back to `zoom` due to lack of more specifi...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-26 10:32 UTC by Giorgio
Modified: 2022-03-21 14:03 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.93


Attachments
GUI in openSuse and OpenMandriva Lx (15.83 KB, image/png)
2022-02-26 10:32 UTC, Giorgio
Details
This is how GUI should appears (from FreeCAD in Appimage) (10.94 KB, image/png)
2022-02-26 10:34 UTC, Giorgio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Giorgio 2022-02-26 10:32:08 UTC
Created attachment 147136 [details]
GUI in openSuse and OpenMandriva Lx

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. install FreeCAD https://www.freecadweb.org/
2. start FreeCAD
3. 

OBSERVED RESULT
see attachement

EXPECTED RESULT
see next comment

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Giorgio 2022-02-26 10:34:16 UTC
Created attachment 147137 [details]
This is how GUI should appears (from FreeCAD in Appimage)

This is how GUI should appears (from FreeCAD in Appimage)
Comment 2 Giorgio 2022-02-26 10:36:09 UTC
I found this problem in openSuse and in OpenMandriva LX, both using KDE.
Comment 3 Nate Graham 2022-03-20 13:57:25 UTC
The icons aren't missing; those *are* the icons in the Breeze theme. I agree that they aren't very good though. Looks like that icon being used for both buttons is `zoom`, which would be the fallback icon in the case of the requested icon not being found in the Breeze icon theme. For example if FreeCAD asks for `zoom-rectangle` (random example) that icon would not exist in the theme so it would fall back to just `zoom`, which does not look very good.

So there are a few issues here:
1. Our Zoom icons are not very good. See Bug 435671
2. We don't have an exact match for whatever icon FreeCad is using. I don't know what it is though. I think we'd need to read the source code in FreeCAD to find out
3. (possibly) FreeCAD is not using the right icon names and should switch to names that are more standard. Would also need to read the source code for this
Comment 4 Giorgio 2022-03-21 10:55:14 UTC
(In reply to Nate Graham from comment #3)
> 2. We don't have an exact match for whatever icon FreeCad is using. I don't
> know what it is though. I think we'd need to read the source code in FreeCAD
> to find out
You can probably find it here https://forum.openmandriva.org/t/freecad-wont-install/4262/32?u=giorgio thanks to excellent work of mandian
Comment 5 Nate Graham 2022-03-21 13:55:42 UTC
Thanks, that's very helpful!

I was right, it's asking for `zoom-all` and `zoom-selection` which don't exist in the Breeze icon theme, so we fall back to `zoom`, which is sort of ugly.

We do have `zoom-select` and `zoom-fit-selection` which are clearly in the same ballpark as `zoom-selection`.

And `zoom-original` seems like a reasonable match for `zoom-all`. I will make some symlinks in the Breeze icon theme so that the icons FreeCad is asking for will map to icons we have. After that, we would need to fix Bug 435671 to get better zoom iconography in general.
Comment 6 Nate Graham 2022-03-21 14:03:57 UTC
Git commit ff66b122c49a4ce33567c78c8367a0f68834c0a4 by Nate Graham.
Committed on 21/03/2022 at 14:03.
Pushed by ngraham into branch 'master'.

Add some more symlinks for zoom icons

Now we also have `zoom-selection` (which is the same as `zoom-select)
and `zoom-all` (which is the same as zoom-original). These icon names
are used by FreeCAD.
FIXED-IN: 5.93

A  +1    -0    icons-dark/actions/16/zoom-all.svg
A  +1    -0    icons-dark/actions/16/zoom-selection.svg
A  +1    -0    icons-dark/actions/22/zoom-all.svg
A  +1    -0    icons-dark/actions/22/zoom-selection.svg
A  +1    -0    icons-dark/actions/32/zoom-all.svg
A  +1    -0    icons-dark/actions/32/zoom-selection.svg
A  +1    -0    icons/actions/16/zoom-all.svg
A  +1    -0    icons/actions/16/zoom-selection.svg
A  +1    -0    icons/actions/22/zoom-all.svg
A  +1    -0    icons/actions/22/zoom-selection.svg
A  +1    -0    icons/actions/32/zoom-all.svg
A  +1    -0    icons/actions/32/zoom-selection.svg

https://invent.kde.org/frameworks/breeze-icons/commit/ff66b122c49a4ce33567c78c8367a0f68834c0a4