Bug 450846 - Group by Author, Publisher, and Keyword pages are empty but don't even show placeholder text
Summary: Group by Author, Publisher, and Keyword pages are empty but don't even show p...
Status: RESOLVED FIXED
Alias: None
Product: peruse
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2022-02-25 21:51 UTC by Nate Graham
Modified: 2022-06-16 20:08 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/peruse/commit/3d67cf4db740cf8ded5900da82c8ed09a62a7866
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-02-25 21:51:31 UTC 
If your book collection doesn't have adequate metadata, these pages are empty, and don't even show some kind of placeholder text. So they look broken.
Comment 1 Remko van Wagensveld 2022-05-19 20:23:23 UTC 
I want to tackle this and understand QML/Qt better by doing this small fix.
Comment 2 Bug Janitor Service 2022-05-29 14:51:34 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/peruse/-/merge_requests/29
Comment 3 Remko van Wagensveld 2022-06-16 20:08:49 UTC 
Git commit 3d67cf4db740cf8ded5900da82c8ed09a62a7866 by Remko van Wagensveld.
Committed on 16/06/2022 at 18:57.
Pushed by ngraham into branch 'master'.

Add placeholder text to empty category pages

This commit adds a PlaceholderMessage to the Bookshelf which is shown if
CategoryEntriesModel.count == 0. This occurs if e.g. there are no comics with
the according metadata in the library.

M  +10   -0    src/app/qml/Bookshelf.qml

https://invent.kde.org/graphics/peruse/commit/3d67cf4db740cf8ded5900da82c8ed09a62a7866