Bug 450785 - Image version hiding not working
Summary: Image version hiding not working
Status: RESOLVED WORKSFORME
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Versioning (other bugs)
Version First Reported In: 7.5.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-24 05:35 UTC by pipo12345
Modified: 2022-04-26 03:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 7.7.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pipo12345 2022-02-24 05:35:06 UTC
SUMMARY
***
Whenever I edit an image (jpg) with the digikam image editor and save the changes as a new version (jpg), the original image still gets shown in e.g. the Thumbnails view even though I have enabled non-destructive editiing and versioning and unchecked the "Always show original images" and  "Always show intermediate snapshots" options.  
***


STEPS TO REPRODUCE
1. Configure Image Editor->Versioning settings as above
2. Edit an image in the Image Editor and save a new version

OBSERVED RESULT
The original image is still shown in the Thumbnails view

EXPECTED RESULT
The original image is hidden in the Thumbnails view

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Ubuntu 20.04.3 LTS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2022-02-24 06:54:37 UTC
Of course, if you save as a new version, the original will not be "hidden". You just have to do a "Save changes".

There is also the possibility that your original images are not original  and already have a history.

I just tested it again, works without any problems.

Maik
Comment 2 pipo12345 2022-02-24 09:04:21 UTC
(In reply to Maik Qualmann from comment #1)
> Of course, if you save as a new version, the original will not be "hidden".
> You just have to do a "Save changes".
> 
> There is also the possibility that your original images are not original 
> and already have a history.
> 
> I just tested it again, works without any problems.
> 
> Maik

Wow, interesting, I thought I've tried that, too. It's indeed working on my side, too, the way you described it.

I would have a follow-up question related to how the versioning and grouping work together. I usually photograph in RAW+JPG and group the RAW and JPG images by filename in digikam. When I then edit the JPG in save it, I afterwards only see the newest JPG version in the Thumbnails view, the complete group including the RAW file being hidden. When I then check "View->Show all grouped items as open", I see the RAW file, the new JPG version and the old JPG version (which represents the group of original RAW+JPG). If I manually group all three files together and uncheck "View->Show all grouped items as open", I don't see any of the three files anymore. I can sort of understand why this is the case, but it be more convenient, if the new JPG version would automatically replace the old JPG version as head of the group.

Is there a way this can be done, or am I missing something? Please also let me know if I should file a new bug/feature request for this.
Comment 3 Maik Qualmann 2022-02-25 09:31:24 UTC
Well, grouping and versioning are completely different things and have nothing to do with each other. Grouping by filename sets the image that is smaller in file size as the leader. The idea here is that the RAW image is larger, so the derived JPG is in front. If you make multiple edits and save, I would only group the images manually afterwards, then you can make the image to the leader, which is the correct one.

Maik
Comment 4 Maik Qualmann 2022-03-20 07:39:57 UTC
Hiding original images in versioning works, I close here.

Maik
Comment 5 pipo12345 2022-04-20 07:40:44 UTC
(In reply to Maik Qualmann from comment #3)
> Well, grouping and versioning are completely different things and have
> nothing to do with each other. Grouping by filename sets the image that is
> smaller in file size as the leader. The idea here is that the RAW image is
> larger, so the derived JPG is in front. If you make multiple edits and save,
> I would only group the images manually afterwards, then you can make the
> image to the leader, which is the correct one.
> 
> Maik

Hi Maik,

thanks for your feedback and sorry for the late reply. Could you quickly tell me how to make a picture the leader of a group? If I e.g. have original images image.JPG and image.RAW and a jpeg edit image_v1.JPG and group those three, then image.JPG shows as leader of the group. How can I make image_v1.JPG the leader?
Comment 6 Peter 2022-04-22 10:40:51 UTC
Hi pipo.
Always the last selected image will leader of the group.
Comment 7 Peter 2022-04-22 10:51:25 UTC
(In reply to Peter from comment #6)
> Hi pipo.
> Always the last selected image will leader of the group.

Sorry... So, always the last selected image will leader of the group... ...in case, if you click the right mouse button over the leader image and select in local menu: group...
Example:
- PIC 1; PIC 2; PIC 3
- Let it be leader of group: PIC 2
- In case select: PIC 1; PIC 3 and finally PIC 2
- Group
Comment 8 pipo12345 2022-04-26 03:43:29 UTC
Wow, that's easy, thanks a lot. Incredible that I didn't stumble about this yet by accident :)