Bug 450655 - Show reboot button after installing some updates that require a reboot, even if more updates are available
Summary: Show reboot button after installing some updates that require a reboot, even ...
Status: CONFIRMED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.23.5
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-21 14:27 UTC by darktemplar
Modified: 2023-01-12 18:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description darktemplar 2022-02-21 14:27:15 UTC
SUMMARY
When doing partial update with offline updates enabled, reboot is not prompted and not hinted. It looks like Discover already finished updating packages while it just scheduled offline update. Issue doesn't reproduce if there are only updates for system packages or all updates are applied.

STEPS TO REPRODUCE
1. Configure and enable offline system updates
2. Ensure that there are updates from multiple sources, for example, system packages and flatpak packages
3. From update window deselect all updates except for system packages. For example, don't update flatpak packages
4. Wait while preparation of offline update for system packages is finished

OBSERVED RESULT
Update for flatpak packages is proposed. No hint at need for reboot.

EXPECTED RESULT
Update for flatpak packages is proposed, but it should be noted that in order to finish offline update a reboot is needed. Button for reboot should be displayed as well.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: ALT Linux
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
For reproduction, in addition to system packages an outdated flatpak package is used To downgrade a flatpak package 'flatpak remote-info --log flathub $PKGNAME' and 'flatpak update --commit=$HASH $PKGNAME' is used.
Comment 1 Nate Graham 2022-02-21 23:48:24 UTC
So you unselected the flatpak updates, but they updated anyway?
Comment 2 Aleix Pol 2022-02-22 00:47:27 UTC
I think that OP means that since there are still updates, Discover never showed the "reboot" page.

Can you confirm my assumption?
Can you also confirm that the system tray did turn into a reboot button?
Comment 3 darktemplar 2022-02-22 07:47:00 UTC
(In reply to Nate Graham from comment #1)
> So you unselected the flatpak updates, but they updated anyway?

No. I deselected flatpak packages, and flatpak packages did not update. That is fine. But I updated system packages, and reboot is actually needed to apply such updates due to offline updates being enabled. And that is not indicated in main window due to flatpak packages being not updated.

(In reply to Aleix Pol from comment #2)
> I think that OP means that since there are still updates, Discover never
> showed the "reboot" page.
> 
> Can you confirm my assumption?

Yes, that is correct.

> Can you also confirm that the system tray did turn into a reboot button?

Yes, tray icon turned into a reboot button. Unfortunately, it's not noticeable enough.