Bug 450472 - Settings -> Configure Umbrello -> User Interface: Text / line / fill color are reset to hard coded values
Summary: Settings -> Configure Umbrello -> User Interface: Text / line / fill color ar...
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-17 15:58 UTC by Oliver Kellogg
Modified: 2022-02-17 16:09 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/sdk/umbrello/commit/6f4fb21ba689b279e2c0ffbe9158c18c3ee5edaf
Version Fixed In: 2.33.80 (KDE releases 22.03.80)

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Kellogg 2022-02-17 15:58:55 UTC 
SUMMARY
***
Settings -> Configure Umbrello -> User Interface: Text / line / fill color are reset to hard coded values.
***

STEPS TO REPRODUCE
1. In main menubar open Settings -> Configure Umbrello -> User Interface.
2. Select one or more of Custom text color, Custom line color, Custom fill color and change the values.
3. Exit and restart Umbrello.

OBSERVED RESULT
On reopening the Settings -> Configure Umbrello -> User Interface and re-selecting the customization buttons, the colors have been reset to hard coded values:
Text color - black
Line color - red
Fill color - light yellow

EXPECTED RESULT
The user chosen colors shall survive the restart.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Oliver Kellogg 2022-02-17 16:09:22 UTC 
Git commit 6f4fb21ba689b279e2c0ffbe9158c18c3ee5edaf by Oliver Kellogg.
Committed on 17/02/2022 at 16:08.
Pushed by okellogg into branch 'master'.

Fix "Settings -> Configure Umbrello -> User Interface: Text / line / fill color are reset to hard coded values"

umbrello/dialogs/pages/uioptionspage.cpp
- Remove #define FILL_COLOR, LINK_COLOR, TEXT_COLOR.
- In function slotTextCBChecked case (value == false) call to
  m_textColorB->setColor() provide m_options->uiState.textColor.
- In function slotLineCBChecked case (value == false) call to
  m_lineColorB->setColor() provide m_options->uiState.lineColor.
- In function slotFillCBChecked case (value == false) call to
  m_fillColorB->setColor() provide m_options->uiState.fillColor.
FIXED-IN:2.33.80 (KDE releases 22.03.80)

M  +3    -8    umbrello/dialogs/pages/uioptionspage.cpp

https://invent.kde.org/sdk/umbrello/commit/6f4fb21ba689b279e2c0ffbe9158c18c3ee5edaf