Bug 450238 - Lock screen icons aren't on the same height when any of them has multi-line label text
Summary: Lock screen icons aren't on the same height when any of them has multi-line l...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.24.0
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-14 17:18 UTC by jasperbakker2
Modified: 2022-04-13 00:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24.2
Sentry Crash Report:


Attachments
An image showing the difference (2.48 MB, image/jpeg)
2022-02-14 17:18 UTC, jasperbakker2
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jasperbakker2 2022-02-14 17:18:42 UTC
Created attachment 146723 [details]
An image showing the difference

STEPS TO REPRODUCE
1. Lock the screen
2. Move the mouse or start to type

OBSERVED RESULT
The lock screen icons with only 1 line of text below them are positioned lower than the ones with 2 lines, which isn't the case in the lock/logout applet. (see attached image)

EXPECTED RESULT
All icons should be on the same height and the text below it should have no influence on the height of the icons.

I think this happens because both the text and the icons are aligned when only the icons should be aligned and the text should simply be positioned below them.

OS INFO:
Operating System: Arch Linux
KDE Plasma Version: 5.24.0
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Kernel Version: 5.16.8-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i5-10300H CPU @ 2.50GHz
Memory: 7.6 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics
Comment 1 Nate Graham 2022-02-15 21:18:55 UTC
Yeah I guess the text height isn't taken into consideration.
Comment 2 Nate Graham 2022-02-16 22:27:43 UTC
Git commit dde0f20b2357a6dd6500e5331c04f14f904f5cc7 by Nate Graham.
Committed on 16/02/2022 at 22:27.
Pushed by ngraham into branch 'master'.

Top-align lock/login/logout screen action buttons

This way the icons are always vertically aligned even when some of
their labels are multi-line strings.
FIXED-IN: 5.24.2

M  +1    -1    lookandfeel/contents/components/SessionManagementScreen.qml
M  +1    -1    lookandfeel/contents/logout/Logout.qml

https://invent.kde.org/plasma/plasma-workspace/commit/dde0f20b2357a6dd6500e5331c04f14f904f5cc7
Comment 3 Nate Graham 2022-02-16 22:29:50 UTC
Git commit b4d5e587f5e676eb54eb4d97342df878811d58e8 by Nate Graham.
Committed on 16/02/2022 at 22:29.
Pushed by ngraham into branch 'Plasma/5.24'.

Top-align lock/login/logout screen action buttons

This way the icons are always vertically aligned even when some of
their labels are multi-line strings.
FIXED-IN: 5.24.2
(cherry picked from commit dde0f20b2357a6dd6500e5331c04f14f904f5cc7)

M  +1    -1    lookandfeel/contents/components/SessionManagementScreen.qml
M  +1    -1    lookandfeel/contents/logout/Logout.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b4d5e587f5e676eb54eb4d97342df878811d58e8
Comment 4 Fushan Wen 2022-04-13 00:18:32 UTC
Git commit 153e6e1401457465990d2ce01da7f9db3012709a by Fushan Wen, on behalf of Eugene Popov.
Committed on 13/04/2022 at 00:14.
Pushed by fusionfuture into branch 'master'.

[Lock Screen] A better fix for BUG 450238

Actually, the commit I reverted doesn't fix the specified bug. But this MR will fix it.

M  +8    -3    lookandfeel/contents/components/SessionManagementScreen.qml
M  +0    -6    lookandfeel/contents/lockscreen/LockScreenUi.qml

https://invent.kde.org/plasma/plasma-workspace/commit/153e6e1401457465990d2ce01da7f9db3012709a