Created attachment 146642 [details] Bold style confuses labels and titles Some labels are styled with bold which make them inconsistent and more noticeable than their titles. See attached image for more info.
Created attachment 146643 [details] Bold style confuses labels and titles 2
This was a change in Kirigami.FormLayout which in retrospect, I'm not super satisfied with. I agree that it makes the labels too attention-getting. We should consider reverting it IMO.
Original MR: https://invent.kde.org/frameworks/kirigami/-/merge_requests/368 I made this change to make forms easier to read on mobile, because otherwise, the content of the form and the labels are the exact same weight with no contrast between them. I guess if the consensus is to revert, that's fine, but I really think it's a downgrade for forms on mobile. Perhaps a compromise would be to use a lighter weight that isn't regular (ex. DemiBold)? I feel like we need a new mobile form style eventually though... the current one feels like an afterthought when compared to other platforms :/
(In reply to espidev from comment #3) > Original MR: https://invent.kde.org/frameworks/kirigami/-/merge_requests/368 > > I made this change to make forms easier to read on mobile, because > otherwise, the content of the form and the labels are the exact same weight > with no contrast between them. I guess if the consensus is to revert, that's > fine, but I really think it's a downgrade for forms on mobile. Bold or size bigger than regular should be used only for titles that group other elements. The problem here is that bold is used on single element and not on a title of group of elements. For example Fill Opacity is part of Appearance group so why that's need bold ? the same for From (Y) and To (Y) in Data Ranges group ?
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/497
Git commit cec5b474765c7c736ea673d86de3b37e68303161 by Nate Graham. Committed on 16/02/2022 at 20:32. Pushed by ngraham into branch 'master'. Revert "Bold labels for narrow FormLayout" This reverts commit 6e3a51678b172cfa4f2f2920bea9dffa71991075. This called too much attention to the labels and violated KDE's general usage of boldness in text. Overall it just didn't really work. We will have to find another way to distinguish labels from controls in narrow and mobile modes. FIXED-IN: 5.92 M +0 -1 src/controls/FormLayout.qml https://invent.kde.org/frameworks/kirigami/commit/cec5b474765c7c736ea673d86de3b37e68303161
Git commit 9b75c59e6f55ce8c192a9938bc3bc362c5a8478b by Nate Graham. Committed on 16/02/2022 at 21:07. Pushed by ngraham into branch 'master'. Use extra spacing to distinguish narrow-mode form labels and UI controls This is less visually heavy but still hopefully groups controls with their labels into logical blocks that are visually parse-able. M +1 -1 src/controls/FormLayout.qml https://invent.kde.org/frameworks/kirigami/commit/9b75c59e6f55ce8c192a9938bc3bc362c5a8478b