Bug 449863 - [FeatureRequest] Follow global theme maybe
Summary: [FeatureRequest] Follow global theme maybe
Status: RESOLVED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: effects-overview (show other bugs)
Version: git-stable-Plasma/5.24
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-09 14:32 UTC by saxn
Modified: 2022-02-11 23:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description saxn 2022-02-09 14:32:15 UTC
SUMMARY
1) If the global theme is dark then the new overview window border highlight (when we hover the cursor over window ) should be white which gives the contrast to the windows and vice versa.
2) Adding close button on the absolute right corner of the windows at the centre corner. (helps to close windows easily)
Comment 1 Vlad Zahorodnii 2022-02-09 14:51:38 UTC
The overview effect pulls the highlight rect from the desktop theme, which is blue-ish with breeze dark. I don't think that it's a good idea to deviate from the desktop theme that plasma uses.

The second point is a good idea, however, it would not align with the existing style. It's worth bringing it up to vdg.
Comment 2 saxn 2022-02-09 14:59:11 UTC
(In reply to Vlad Zahorodnii from comment #1)
> The overview effect pulls the highlight rect from the desktop theme, which
> is blue-ish with breeze dark. I don't think that it's a good idea to deviate
> from the desktop theme that plasma uses.
> 
> The second point is a good idea, however, it would not align with the
> existing style. It's worth bringing it up to vdg.

If user added active window glow from "Global theme > Window Decoration > Oxygen > Active window glow" then the the preview of the overview effect is more dominate with the Active window glow then blue-ish color. Also, the opposite color contrast also helps the user to be more friendly. Maybe ?
Comment 3 Vlad Zahorodnii 2022-02-09 15:03:20 UTC
The overview effect uses the desktop theme, it's configured in Appearance > Plasma Style.
Comment 4 saxn 2022-02-09 15:09:38 UTC
(In reply to Vlad Zahorodnii from comment #3)
> The overview effect uses the desktop theme, it's configured in Appearance >
> Plasma Style.

Okey, border looks fine but can we disable "Active window glow" in overview ? It would be great.
Comment 5 Vlad Zahorodnii 2022-02-09 22:51:40 UTC
We can't do anything about that as the glow comes from the decoration and the overview effect has no idea what the deco does exactly. I think it's also the case with other fullscreen effects in kwin.
Comment 6 Nate Graham 2022-02-11 23:37:48 UTC
Yes, I think so.