Created attachment 146414 [details] Clicking on checkbox doesn't let user install addons SUMMARY If you click in a checkbox on the addons page the Apply Changes button stays grayed out. If you click on the text it starts working. After clicking the text, subsequent clicks on the checkbox also work. Check the attached video for details. STEPS TO REPRODUCE 1. Open Discover 2. Search Dolphin 3. Scroll and click on "Addons" 4. Click in one of the checkboxes (do not click on the label, only on the checkbox) OBSERVED RESULT Apply Changes button is still greyed out EXPECTED RESULT Clicking on the checkbox or the label should always let the user apply changes. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.24.80 KDE Frameworks Version: 5.91.0 Qt Version: 5.15.3 Kernel Version: 5.13.0-28-generic (64-bit) Graphics Platform: Wayland Processors: 6 × Intel® Core™ i5-9400F CPU @ 2.90GHz Memory: 7,6 GiB of RAM Graphics Processor: Radeon RX 570 Series
Can reproduce with Discover 5.24. Operating System: Arch Linux KDE Plasma Version: 5.24.0 KDE Frameworks Version: 5.90.0 Qt Version: 5.15.2 Graphics Platform: Wayland
Oh my goodness. This might be an issue in Discover's implementation of CheckableListItem, or it is (more likely) an issue with that component itself. I will investigate.
Man, I really botched this API when I wrote the component. :(
Found the issue and it's an implementation problem in Discover. Fix incoming.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/256
Git commit 8129152a24d10ff50cbdfb7ea72422dd91fbeb25 by Nate Graham. Committed on 08/02/2022 at 19:08. Pushed by ngraham into branch 'master'. Implement Kirigami.CheckableListItem properly We don't need an action here, we just need to listen for when the checked status changes. FIXED-IN: 5.24.1 M +1 -6 discover/qml/AddonsView.qml https://invent.kde.org/plasma/discover/commit/8129152a24d10ff50cbdfb7ea72422dd91fbeb25
Git commit 3674bc6bd436b5e0bb7f82171a6d47e62b442a37 by Nate Graham. Committed on 08/02/2022 at 20:18. Pushed by ngraham into branch 'Plasma/5.24'. Implement Kirigami.CheckableListItem properly We don't need an action here, we just need to listen for when the checked status changes. FIXED-IN: 5.24.1 (cherry picked from commit 8129152a24d10ff50cbdfb7ea72422dd91fbeb25) M +1 -6 discover/qml/AddonsView.qml https://invent.kde.org/plasma/discover/commit/3674bc6bd436b5e0bb7f82171a6d47e62b442a37
This bug persists on Arch Linux. Can reproduce with Ark. Operating System: Arch Linux KDE Plasma Version: 5.24.1 KDE Frameworks Version: 5.91.0 Qt Version: 5.15.2 Graphics Platform: Wayland
You also need frameworks 5.92 for it to be fully fixed. It turned out that there was also an issue with the Kirigami component that has to be fixed.
Git commit cbf03860f365b463eefaa0d534afc7948520d7ba by Nate Graham. Committed on 15/02/2022 at 18:02. Pushed by ngraham into branch 'master'. CheckableListItem: Reset list item's checked property when checking box Otherwise they can drift out of sync, which is bad. M +2 -0 src/controls/CheckableListItem.qml https://invent.kde.org/frameworks/kirigami/commit/cbf03860f365b463eefaa0d534afc7948520d7ba