Bug 449759 - Tools Area appearance not used for GTK menu bar in Electron programs
Summary: Tools Area appearance not used for GTK menu bar in Electron programs
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (other bugs)
Version First Reported In: 5.23.5
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-07 20:31 UTC by Grzesiek11
Modified: 2022-05-10 21:12 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/breeze-gtk/commit/90c9a9d40f298186e1b9072701b3a8383f980d45
Version Fixed In: 5.25
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Grzesiek11 2022-02-07 20:31:43 UTC 
SUMMARY
Electron apps that use a GTK (NOT browser-rendered) menu bar, for example VSCodium, use the wrong color for it when the window is not active.
With Breeze Dark color scheme it's #31363b for the window bar and #2a2e32 for the header. With Breeze Light it's #dee0e2 and #eff0f1 instead.
This is a regression, but I don't know the version it stopped working correctly.

STEPS TO REPRODUCE
1. Launch VSCodium.
2. Compare the color between the window bar and the program header.

OBSERVED RESULT
The color is different.

EXPECTED RESULT
The color is the same.

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel Version: 5.16.0-5.1-liquorix-amd64 (64-bit)
Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 2600 Six-Core Processor
Memory: 15.6 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 660/PCIe/SSE2

ADDITIONAL INFORMATION
How it looks like (screenshot): https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004135.png
How it should look like (edited screenshot): https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004135_improved.png
Comment 1 Nate Graham 2022-05-10 21:12:15 UTC 
Git commit 90c9a9d40f298186e1b9072701b3a8383f980d45 by Nate Graham, on behalf of Artem Grinev.
Committed on 10/05/2022 at 21:12.
Pushed by ngraham into branch 'master'.

gtk3,gtk4: Use Header colors for menubars

Applying this to toolbars will require additional research and maybe app-specific
hacks, as GTK uses toolbars for more than just window headers.
Related: bug 445952, bug 448941
FIXED-IN: 5.25

M  +2    -2    src/gtk3/widgets/_menus.scss
M  +2    -2    src/gtk4/widgets/_menus.scss

https://invent.kde.org/plasma/breeze-gtk/commit/90c9a9d40f298186e1b9072701b3a8383f980d45