Bug 449493 - The view in compact mode moves to the opposite side of horizontal scroll bar direction in RTL mode
Summary: The view in compact mode moves to the opposite side of horizontal scroll bar ...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: compact mode (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: rtl
Depends on:
Blocks:
 
Reported: 2022-02-02 11:39 UTC by Zayed Al-Saidi
Modified: 2024-03-27 10:28 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
moving the view in Compact view in RTL environment . (882.46 KB, video/webm)
2022-02-02 11:39 UTC, Zayed Al-Saidi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zayed Al-Saidi 2022-02-02 11:39:33 UTC
Created attachment 146169 [details]
moving the view in Compact view in RTL environment .

SUMMARY
***
In RTL mode, the compact view moves in the opposite of the horizontal scroll bar direction. Please see the screen record in the attachment. 


***


STEPS TO REPRODUCE
1. Run dolphin --reverse 
2. Set the compact view and open any directory includes many files and folders. For example /usr/share/
3. move the horizontal scroll bar from right to left 

OBSERVED RESULT
The view moves from left to right

EXPECTED RESULT
The view moves same direction of horizontal scroll bar (i.e. from right to left)

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Kernel Version: 5.11.0-40-generic (64-bit)
Graphics Platform: X11
Processors: 3 × AMD Ryzen 9 3900X 12-Core Processor
Memory: 4.9 غ.بايت of RAM
Graphics Processor: llvmpipe
ADDITIONAL INFORMATION
Comment 1 ratijas 2023-09-03 19:10:30 UTC
The offending function here is `void KItemListViewLayouter::doLayout()`. The whole thing just assumes that you can swap vertical scroll direction with horizontal, and then transpose the result, which is obviously wrong for RTL.
Comment 2 Bug Janitor Service 2024-03-24 11:03:26 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/742
Comment 3 Méven Car 2024-03-27 10:28:18 UTC
Git commit 240d33ce17fc531e8bc6638af8f71454fe7c05e6 by Méven Car, on behalf of Eugene Popov.
Committed on 27/03/2024 at 10:28.
Pushed by meven into branch 'master'.

Better support for RTL

This MR fixes some issues related to RTL scripts:
- wrong layout in Compact View mode
- broken horizontal scrolling in Icon View and Details View modes
- broken navigation with left and right arrow keys in Details View mode
Related: bug 484012

M  +5    -0    src/kitemviews/kitemlistcontainer.cpp
M  +39   -23   src/kitemviews/kitemlistcontroller.cpp
M  +4    -0    src/kitemviews/kitemlistview.cpp
M  +10   -3    src/kitemviews/kstandarditemlistwidget.cpp
M  +20   -10   src/kitemviews/private/kitemlistviewlayouter.cpp
M  +1    -1    src/tests/kitemlistcontrollertest.cpp

https://invent.kde.org/system/dolphin/-/commit/240d33ce17fc531e8bc6638af8f71454fe7c05e6