SUMMARY As noted in this[1] thread, the battery icon is only 10-11px vs whooping 15-16px height keyboard toolbar buttons' icons on the left. There is something wrong about this Battery.qml component: it has a `property int fontSize` but it is a Row -- not a Control, so when not binding the font externally explicitly, it is using the default value of `PlasmaCore.Theme.defaultFont.pointSize`. Other than that, it doesn't seem like a good idea to bind icon's height to the text Label's height: Label is a Control potentially with a padding and whatnot. Looks like ToolBar button calculates its icon size in a different way. [1]: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1422#note_390119 STEPS TO REPRODUCE 1. Have a battery (power supply) installed 2. Lock the screen or log out to SDDM with breeze theme OBSERVED RESULT Battery icon is small. EXPECTED RESULT Battery and Keyboard icons should have the same size. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.24.80 KDE Frameworks Version: 5.91.0 Qt Version: 5.15.2 Kernel Version: 5.16.2-arch1-1 (64-bit) Graphics Platform: X11 Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz Memory: 15.6 GiB of RAM Graphics Processor: NVIDIA GeForce GTX 970M/PCIe/SSE2
Yeah we should use a standard icon size here, rather than matching a font pixel size.
Git commit 6a71c119ef5153631d60b4b276b2a8efbfb68f17 by Nate Graham, on behalf of ivan tkachenko. Committed on 18/05/2022 at 00:23. Pushed by ngraham into branch 'master'. lookandfeel: fix battery icon on lock/login screens being too small Now it does not attempt to fix into the height of a line. FIXED-IN: 5.25 M +6 -3 lookandfeel/contents/components/Battery.qml https://invent.kde.org/plasma/plasma-workspace/commit/6a71c119ef5153631d60b4b276b2a8efbfb68f17