Bug 449393 - XMI load in git version fails
Summary: XMI load in git version fails
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: importer (show other bugs)
Version: Git
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-30 22:44 UTC by Jessica
Modified: 2022-02-10 19:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.33.80 (KDE releases 22.03.80)
Sentry Crash Report:


Attachments
XMI file (271.37 KB, application/xml)
2022-01-30 22:44 UTC, Jessica
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jessica 2022-01-30 22:44:46 UTC
Created attachment 146086 [details]
XMI file

Creating XMI file with version 

https://download.kde.org/stable/umbrello/latest/win64/umbrello-mingw64-2.32.0-126.1-setup.exe 

and loading with git version 

https://binary-factory.kde.org/job/Umbrello_Nightly_win64/lastSuccessfulBuild/artifact/umbrello-master-1420-windows-msvc2019_64-cl.exe 

(https://binary-factory.kde.org/job/Umbrello_Nightly_win64/  downloaded 30/01/2022 23:49)

doesn't load in the git version.

STEPS TO REPRODUCE
1.  Create XMI file with old version
2.  Load XMI with git version
3. XMI doesn't load
"Loading listview" in status bar, but program exits. No crash , no warning.

OBSERVED RESULT
XMI file from older version doesn't load 

EXPECTED RESULT
XMI file should load everywhere

SOFTWARE/OS VERSIONS
Windows: 
Git version from KDE binary factory

ADDITIONAL INFORMATION
XMI file is attached
Comment 1 Jessica 2022-01-31 00:57:28 UTC
The xmi file was made by importing python source code here:

https://pacmancode.com/
Comment 2 Jessica 2022-01-31 21:50:33 UTC
Also when disabling "Enable UML2 support" the XMI file is not loaded.
Comment 3 Jessica 2022-02-05 16:48:58 UTC
Current git b3c005b (KDE binary factory) doesn't load XMI file made with Umbrello 2.32.
When "loading listview" , umbrello uses 9 GB (!) of RAM and windows says "the program doesn't respond".
The file is never loaded no matter how long you wait.
Comment 4 Oliver Kellogg 2022-02-05 23:25:11 UTC
This has been fixed.
Comment 5 Oliver Kellogg 2022-02-10 15:25:42 UTC
(In reply to Oliver Kellogg from comment #4)
> This has been fixed.

On looking again, that is perhaps an oversimplification.
"Fixed" just means that checks were added to refuse to set rogue x / y coordinate value on widgets.
See bug 449622.
Comment 6 Oliver Kellogg 2022-02-10 19:43:25 UTC
Git commit fdbc8b6a972923e5f21e77c66a6630b97dbf3501 by Oliver Kellogg.
Committed on 10/02/2022 at 19:43.
Pushed by okellogg into branch 'master'.

https://bugs.kde.org/show_bug.cgi?id=449393#c5 followup to commit 6085771

> "Fixed" just means that checks were added to refuse to set rogue x/y
> coordinate value on widgets.

umbrello/umlscene.{h,cpp}
- Change the impl local static const maxCanvasSize to class level static
  s_maxCanvasSize.
- Add getter maxCanvasSize() returning s_maxCanvasSize.

umbrello/umlwidgets/umlwidget.cpp
- In functions setX and setY, if the argument is below -maxCanvasSize()
  or above maxCanvasSize() then log an error and do not change the
  widget coordinate.

M  +5    -5    umbrello/umlscene.cpp
M  +4    -1    umbrello/umlscene.h
M  +8    -2    umbrello/umlwidgets/umlwidget.cpp

https://invent.kde.org/sdk/umbrello/commit/fdbc8b6a972923e5f21e77c66a6630b97dbf3501