SUMMARY Order of input elements wrong when cycling through with TAB key in KCM "Advanced Power Settings" STEPS TO REPRODUCE 1. Open powerdevil's kcm, go to "Advanced Power settings". 2. Focus the first input field, to enter a number. 3. Press tab multiple times. OBSERVED RESULT The order is the following: low level -> critical level-> at critical level -> low level for peripheral devices -> start charging once below -> pause media players -> configure notifications -> stop charging at EXPECTED RESULT The order should be like the input elements are layout out from top to bottom: low level -> critical level-> at critical level -> low level for peripheral devices -> start charging once below -> stop charging at -> pause media players -> configure notifications
Git commit 127f6aef4ec9626e95c200d5600655bc781b45d6 by Jakob Petsovits. Committed on 15/12/2023 at 07:21. Pushed by jpetso into branch 'master'. Drop "Advanced Power Settings" KCM in favor of a new QML page This commit removes the QWidgets-based KCM in kcmodule/global, and instead adds a new QML page accessible via header action in the existing "Energy Saving" (QML) KCM a.k.a. profiles config. Renaming folder and class names of the profiles KCM to reflect its combined scope is left for a later commit. I modified the "Energy Saving" KCM's JSON file to declare it on the top level of System Settings, and merged extra keywords from the now deleted kcm_powerdevilglobalconfig.json. We'll have to remove the "power-management" category from System Settings after this, as only a single KCM is left. New C++ KCM backend code is mostly moved from GeneralPage.{h,cpp}: * PowerDevil::GlobalSettings provides kcm.settings.global for QML. * KAuth-powered ChargeThresholdHelper settings are accessible via kcm.externalServiceSettings & left out of non-default highlighting. * "Supports $X" properties are added to the KCM class directly. All in all, it's a fairly straight port that doesn't change the underlying data representation apart from the obvious C++/QML split. Only the magic value -1 gets replaced by a constant named ChargeThresholdUnsupported, plus functions for checking support. The UI is also roughly the same. That said, there are some differences: * I replaced the "Configure Notifications" button with a column of two ToolButtons in the style of Quick Settings' "Most used pages". * The start-charging threshold, i.e. the lower bound, previously had a weirdly long spinbox field because it needed to fit the "special value" text "Always charge when plugged in". This looks awkward and is not easily discoverable. Furthermore, QQC2.SpinBox doesn't have a concept of a "special value" and doesn't pre-allocate item width for any given space. I decided to represent this state with numeric percentages only. * "Special value" means display text for the minimum value ("from") of a QSpinBox. The start-charging threshold QSpinBox had no minimum set in generalPage.ui, so its "special value" would have been 0. This makes little sense, "Always charge" for the start threshold is conceptually more similar to "start threshold equals stop threshold". * Hence, the start threshold SpinBox now starts at 1, not 0, and the maximum allowed value is that of the stop threshold from the other field above. If the maximum value is selected, we write the "special value" 0 to the backend. If the backend value changes to 0, we set the UI to the stop threshold value. Related: bug 450276, bug 459081, bug 467797 M +0 -2 kcmodule/CMakeLists.txt M +0 -1 kcmodule/common/CMakeLists.txt D +0 -90 kcmodule/common/ErrorOverlay.cpp D +0 -28 kcmodule/common/ErrorOverlay.h D +0 -19 kcmodule/global/CMakeLists.txt D +0 -266 kcmodule/global/GeneralPage.cpp D +0 -47 kcmodule/global/GeneralPage.h D +0 -4 kcmodule/global/Messages.sh D +0 -277 kcmodule/global/generalPage.ui D +0 -126 kcmodule/global/kcm_powerdevilglobalconfig.json M +3 -1 kcmodule/profiles/CMakeLists.txt A +190 -0 kcmodule/profiles/ExternalServiceSettings.cpp [License: GPL(v2.0+)] A +66 -0 kcmodule/profiles/ExternalServiceSettings.h [License: GPL(v2.0+)] M +0 -2 kcmodule/profiles/Messages.sh M +107 -5 kcmodule/profiles/ProfilesConfigKCM.cpp M +41 -2 kcmodule/profiles/ProfilesConfigKCM.h M +32 -31 kcmodule/profiles/kcm_powerdevilprofilesconfig.json A +364 -0 kcmodule/profiles/ui/GlobalConfig.qml [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] A +53 -0 kcmodule/profiles/ui/MostUsedItem.qml [License: LGPL(v2.0)] M +8 -1 kcmodule/profiles/ui/main.qml https://invent.kde.org/plasma/powerdevil/-/commit/127f6aef4ec9626e95c200d5600655bc781b45d6