Created attachment 145982 [details] Konsole 21.12.1 oxygen SUMMARY *** Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion). In 21.08.3 it was working. *** STEPS TO REPRODUCE 1. Set Fusion Application theme from settings. 2. Open Konsole and edit current profile. 3. From the Appareance section change the color scheme. OBSERVED RESULT The scrollbar keeps the color of the Global color scheme. EXPECTED RESULT The scrollbar take the color of the Konsole profile color scheme. SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Plasma Version: 5.23.5 KDE Frameworks Version: 5.90 Qt Version: 5.15.2 ADDITIONAL INFORMATION
Created attachment 145983 [details] konsole 21.12.1 fusion
Created attachment 145984 [details] konsole 21.08.03 oxygen
Created attachment 145985 [details] konsole 21.08.03 fusion
Created attachment 145986 [details] 21.08.03 light theme oxygen
It was causing visibility issues for many people (https://bugs.kde.org/show_bug.cgi?id=393423). Introducing a configuration option was proposed in https://invent.kde.org/utilities/konsole/-/merge_requests/402 but was ultimately rejected. Then in https://invent.kde.org/utilities/konsole/-/merge_requests/511 taking the scrollbar colors from the color scheme was removed, and finally in https://invent.kde.org/utilities/konsole/-/commit/8d2582b000f2a3dcf6ec946f70af8f9aa753fa02 it was introduced only for Breeze styles.
Ok... but it's very bad to remove features to fix bugs... I'm not a user of the breeze theme and now with dark color schemes it looks ugly.. Adding an option to toggle it was much better than removing a feature or adding a ugly hack in the code to make it work only with the breeze theme.....
Sorry for my previous rude comment but i liked that feature very much.... If it was causing problems to many people it was not better to make an option and leave it disabled by default... Adding an hardcoded check in the code only for a style is not very nice.... Thank you anyway...
Hi i liked this feature a lot.... it is very disappointing that is not available anymore.... Im a oxygen theme user.
Changing the colour scheme of all the widgets in the app doesn't work? Settings -> Window colour scheme.
(In reply to Ahmad Samir from comment #9) > Changing the colour scheme of all the widgets in the app doesn't work? > Settings -> Window colour scheme. Yes but changing the window color scheme is another thing.... Before 21.12.1 the scrollbar blended with the terminal color scheme indipendent of the window color scheme ... and i think that feature was introduced 1-2 years ago.. is not very nice to remove a feature that was around for a very long time without giving users an option to re enable it... now it works only using breeze... but i dont use it. (In reply to Ahmad Samir from comment #9) > Changing the colour scheme of all the widgets in the app doesn't work? > Settings -> Window colour scheme.
That "feature" was removed because it only worked with Breeze, with Oxygen, Fusion ...etc, sometimes one ended up with a black scrollbar on a black background, where you couldn't easily distinguish the position of the scrollbar in the gutter. A feature that causes a bug, for people with vision impairment, was reverted (and should have been reverted 1-2 years ago). You could select a colour scheme for the widget style that matches the terminal colour scheme?
*** Bug 449311 has been marked as a duplicate of this bug. ***
(In reply to Ahmad Samir from comment #11) > That "feature" was removed because it only worked with Breeze, with Oxygen, > Fusion ...etc, sometimes one ended up with a black scrollbar on a black > background, where you couldn't easily distinguish the position of the > scrollbar in the gutter. > > A feature that causes a bug, for people with vision impairment, was reverted > (and should have been reverted 1-2 years ago). > > You could select a colour scheme for the widget style that matches the > terminal colour scheme? I understand the point of people with vision impairment and i respect it.. but you should also understand point of view of people who liked that "feature" and used it for years... I respect your work but was not better to simply make it optional and make it disabled by default to help people with vision impairment. And no. I don't want to change the window color scheme to match that of the terminal. It is also impossible because i use another nice looking "feature" of the Konsole terminal emulator: i use a terminal color theme with a random background color and i cannot guess wich color the terminal will be. What i should do? Change the window color theme manually each time i open a new window or tab? Best regards.
*** This bug has been confirmed by popular vote. ***
(In reply to Ahmad Samir from comment #11) > That "feature" was removed because it only worked with Breeze, with Oxygen, > Fusion ...etc, sometimes one ended up with a black scrollbar on a black > background, where you couldn't easily distinguish the position of the > scrollbar in the gutter. > > A feature that causes a bug, for people with vision impairment, was reverted > (and should have been reverted 1-2 years ago). > > You could select a colour scheme for the widget style that matches the > terminal colour scheme? I also don't understand why it was removed after so long time without giving the user any way to re-enable it. I use oxygen and scrollbar colors blended with the terminal very nicely before and now it looks ugly. You call this a "feature" but are also "features" like this that make the difference... and made Konsole very modern-looking ad stand out from other terminal emulators.
Created attachment 146052 [details] random color background 21.08.3 nice looking
Created attachment 146053 [details] random color 21.12.1 regression
From my point of view, the scrollbar belongs to the window widget style, the terminal colour scheme shouldn't affect it, since the scrollbar is technically not part of the terminal display in the first place. The behaviour to make the scrollbar match the terminal background colour wasn't a good one, in my opinion. We also got bug reports about that matching going wrong and the scrollbar becoming invisible, see the screenshots from bug 393423. Providing a setting for every bit where it works sometimes and breaks some other times would create bigger and bigger config dialogs, and complicate the code, needlessly. My 2p's.
(In reply to Ahmad Samir from comment #18) > From my point of view, the scrollbar belongs to the window widget style, the > terminal colour scheme shouldn't affect it, since the scrollbar is > technically not part of the terminal display in the first place. The > behaviour to make the scrollbar match the terminal background colour wasn't > a good one, in my opinion. We also got bug reports about that matching going > wrong and the scrollbar becoming invisible, see the screenshots from bug > 393423. Ok but now if you use Breeze you get the color matching the terminal background, if not you get the color from the window ... this is more inconsistent to me. > Providing a setting for every bit where it works sometimes and breaks some > other times would create bigger and bigger config dialogs, and complicate > the code, needlessly. in the code now you have this: if (appStyle->objectName() == QLatin1String("breeze")) { setPalette(_backgroundMatchingPalette); } else { setPalette(QGuiApplication::palette()); } So the code to make this work it's still there there is no complication.. Is it not better than giving the user the choice? In KDE there you can customize the color of window decoration for each window. Some applications like kate and Konsole permit to use of a custom color for the entire window and in Konsole you can customize the color of each tab... So there are plenty of customization options.... and I don't think that adding a checkbox in the scrollbar settings will make the configuration so big and complicated. I don't understand why not give the user the choice for a feature that was already there for years....
(In reply to Giovanni Santoni from comment #19) > (In reply to Ahmad Samir from comment #18) > > From my point of view, the scrollbar belongs to the window widget style, the > > terminal colour scheme shouldn't affect it, since the scrollbar is > > technically not part of the terminal display in the first place. The > > behaviour to make the scrollbar match the terminal background colour wasn't > > a good one, in my opinion. We also got bug reports about that matching going > > wrong and the scrollbar becoming invisible, see the screenshots from bug > > 393423. > > Ok but now if you use Breeze you get the color matching the terminal > background, if not you get the color from the window ... > this is more inconsistent to me. > If it were solely my decision, the change to make the scrollbar colours match the background colour of the terminal colour scheme wouldn't have been added back. > > Providing a setting for every bit where it works sometimes and breaks some > > other times would create bigger and bigger config dialogs, and complicate > > the code, needlessly. > > > in the code now you have this: > if (appStyle->objectName() == QLatin1String("breeze")) { > setPalette(_backgroundMatchingPalette); > } else { > setPalette(QGuiApplication::palette()); > } > > So the code to make this work it's still there there is no complication.. > > Is it not better than giving the user the choice? > > In KDE there you can customize the color of window decoration for each > window. > Some applications like kate and Konsole permit to use of a custom color for > the entire window and in Konsole you can customize the color of each tab... > So there are plenty of customization options.... and I don't think that > adding a checkbox in the scrollbar settings will make the configuration so > big and complicated. > > I don't understand why not give the user the choice for a feature that was > already there for years....
(In reply to Ahmad Samir from comment #18) And in the kde gears release notes https://kde.org/announcements/gear/21.12.0/ there is this statement in the Konsole section: "It is important to use applications that are visually appealing, but, as beauty is in the eyes of the beholder, Konsole, in classic KDE fashions gives you plenty of chances of customizing its look to your taste." So please give the users the choice.
(In reply to Ahmad Samir from comment #18) And sorry if I insist but the person that reported bug 393423 and also some people in the comments where simply asking to add an option to disable it.
*** Bug 449356 has been marked as a duplicate of this bug. ***
I will copy my post here: Dear Konsole developers, I'm using KDE Neon with KDE Konsole 21.12.1 and since the latest update, the konsole's scrollbar does not change his color anymore to adapt to my "black on random light color" terminal color scheme. I'm use the "old fashion" Oxygen theme and now it looks ugly this way. I found that this was removed by git commit #92e19c6305e917bafb198b57dcde9cf0f9b35896 but i didn't find any options to re enable it. The strange thing is that using the Breeze theme it is working.... it looks a very inconsistent behaviour. Please provide an option so that it can be re-enabled!!! Thank you! Carlos Alberto Martìnez
I will also vote for having an option to enable it again with the oxygen theme. I tried the new Konsole version using Kubuntu 21.10 backports. IMHO the old behavior was much more consistent when using a random background color. For now i will stick with 21.08.
Created attachment 146160 [details] attachment-20044-0.html People, anyone here is willing to try to add that option? I'd gladly accept patches for that. On Wed, Feb 2, 2022 at 10:38 AM Isabella Nadine <bugzilla_noreply@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=449236 > > Isabella Nadine <sbllnadine@gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| |sbllnadine@gmail.com > > --- Comment #25 from Isabella Nadine <sbllnadine@gmail.com> --- > I will also vote for having an option to enable it again with the oxygen > theme. > I tried the new Konsole version using Kubuntu 21.10 backports. > IMHO the old behavior was much more consistent when using a random > background > color. > > For now i will stick with 21.08. > > -- > You are receiving this mail because: > You are the assignee for the bug.
Created attachment 146161 [details] old behavior
Created attachment 146162 [details] new behavior
Created attachment 146187 [details] scrollbar match terminal patch for 21.12.1
(In reply to tcanabrava from comment #26) > Created attachment 146160 [details] > attachment-20044-0.html > > People, anyone here is willing to try to add that option? > I'd gladly accept patches for that. I created a patch for Tag 21.12.1. I tested it and seem to work. I added the option inProfile->Appareance->Miscellaneous
Created attachment 146188 [details] setting
(In reply to tcanabrava from comment #26) > Created attachment 146160 [details] > attachment-20044-0.html > > People, anyone here is willing to try to add that option? > I'd gladly accept patches for that. The patch works well also with 21.12.2.
(In reply to Giovanni Santoni from comment #30) > I created a patch for Tag 21.12.1. I tested it and seem to work. > > I added the option inProfile->Appareance->Miscellaneous Thank you Giovanni
Same issue here. Not good to remove functions to fix bugs.
*** Bug 449712 has been marked as a duplicate of this bug. ***
(In reply to tcanabrava from comment #26) > Created attachment 146160 [details] > attachment-20044-0.html > > People, anyone here is willing to try to add that option? > I'd gladly accept patches for that. @tcanabrava@kde.org. Hi any news about the patch? or should i register on kde gitlab and create a merge request?
Created attachment 146482 [details] attachment-13430-0.html Sorry, real life got me. It’s always better to send patches trough the gitlab instance at invent.kde.org Le mer. 9 févr. 2022 à 08:10, Giovanni Santoni <bugzilla_noreply@kde.org> a écrit : > https://bugs.kde.org/show_bug.cgi?id=449236 > > Giovanni Santoni <giovanni.santoni72@gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| |tcanabrava@kde.org > > --- Comment #36 from Giovanni Santoni <giovanni.santoni72@gmail.com> --- > (In reply to tcanabrava from comment #26) > > Created attachment 146160 [details] > > attachment-20044-0.html > > > > People, anyone here is willing to try to add that option? > > I'd gladly accept patches for that. > @tcanabrava@kde.org. > Hi any news about the patch? or should i register on kde gitlab and create > a > merge request? > > -- > You are receiving this mail because: > You are the assignee for the bug.
(In reply to tcanabrava from comment #37) > Created attachment 146482 [details] > attachment-13430-0.html > > Sorry, real life got me. > It’s always better to send patches trough the gitlab instance at > invent.kde.org > No. I am sorry to disturb you with such trivial requests .... Btw i will try to create a merge request when my real life allows me. Thank you !!
*** Bug 451176 has been marked as a duplicate of this bug. ***