Bug 449138 - Pinning KRunner doesn't keep it open when clicking entries
Summary: Pinning KRunner doesn't keep it open when clicking entries
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: 5.23.5
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Alexander Lohnau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-25 12:44 UTC by Gabriel
Modified: 2022-02-10 14:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel 2022-01-25 12:44:12 UTC
SUMMARY
KRunner has a feature which allows you to pin it to keep it open, but when you click any entry or press enter, that fails and it still closes.

STEPS TO REPRODUCE
1. Open KRunner
2. Click the pin/keep open button
3. Type something
4. Click the option

OBSERVED RESULT
KRunner closes, as if it wasn't pinned

EXPECTED RESULT
KRunner stays open

SOFTWARE
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
A similar issue was once present in Kickoff (BUG 443589). Possibly the solution may be similar too?
Comment 1 Nate Graham 2022-01-25 21:13:06 UTC
Can confirm.
Comment 2 Bug Janitor Service 2022-01-27 18:36:48 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1413
Comment 3 Nate Graham 2022-01-27 20:03:38 UTC
Git commit 738b41d25c8d1be969a9d775cb785f07a2e439a9 by Nate Graham, on behalf of Alexander Lohnau.
Committed on 27/01/2022 at 20:03.
Pushed by ngraham into branch 'master'.

Keep KRunner open after launching matches when it is pinned
FIXED-IN: 5.24

M  +3    -1    lookandfeel/contents/runcommand/RunCommand.qml

https://invent.kde.org/plasma/plasma-workspace/commit/738b41d25c8d1be969a9d775cb785f07a2e439a9
Comment 4 Nate Graham 2022-01-27 20:04:59 UTC
Git commit b82d67b950dcc0fa44642d36fd69c6e3a2c394c1 by Nate Graham, on behalf of Alexander Lohnau.
Committed on 27/01/2022 at 20:04.
Pushed by ngraham into branch 'Plasma/5.24'.

Keep KRunner open after launching matches when it is pinned
FIXED-IN: 5.24


(cherry picked from commit 738b41d25c8d1be969a9d775cb785f07a2e439a9)

M  +3    -1    lookandfeel/contents/runcommand/RunCommand.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b82d67b950dcc0fa44642d36fd69c6e3a2c394c1
Comment 5 Mykola Krachkovsky 2022-02-10 14:34:07 UTC
Hmm. I kinda loved previous behaviour. When activity goes to other window, it keeps active, but when Enter pressed it hides as no longer needed. Right now both not pinned and pinned aren't what I like. In first case I can't keep calculations always visible, in second after running apps it still opened and cover app, so I need to switch to it and press Esc.

I'd like to add option for that, would it be welcomed or not (as extra option somewhere)?