Bug 449083 - Critical Notification line is not clipped to notification's shape, whatever it is
Summary: Critical Notification line is not clipped to notification's shape, whatever i...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.23.90
Platform: openSUSE Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-24 16:49 UTC by Egor Kuznetsov
Modified: 2025-03-29 18:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.4
Sentry Crash Report:


Attachments
Screenshot of bug (45.76 KB, image/png)
2022-01-24 16:49 UTC, Egor Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Egor Kuznetsov 2022-01-24 16:49:27 UTC
Created attachment 145865 [details]
Screenshot of bug

SUMMARY
Vertical color bar out of border on notification popups with rounded borderds


STEPS TO REPRODUCE
1. Wait for notification or manually call notification popup 

OBSERVED RESULT
Vertical bar out of border of popup

EXPECTED RESULT
Bar adjust to the popup borders

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20220122 with KDE Beta (not unstable) repos
KDE Plasma Version: 5.23.90
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Kernel Version: 5.16.1-1-default (64-bit)
Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 5500U with Radeon Graphics
Memory: 15.0 GiB of RAM
Graphics Processor: AMD RENOIR
Comment 1 Nate Graham 2022-01-24 22:08:11 UTC
Looks like this visualization doesn't work at all with Plasma themes that have a giant corner radius.
Comment 2 Bug Janitor Service 2025-01-26 21:14:39 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5125
Comment 3 Bug Janitor Service 2025-03-29 13:56:35 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5354
Comment 4 Nate Graham 2025-03-29 17:50:17 UTC
Git commit a4d20ab762ce39401cf1d3b24895453169ff38ab by Nate Graham.
Committed on 29/03/2025 at 13:53.
Pushed by ngraham into branch 'master'.

applets/notifications: tighten internal spacings

This restores the spacing seen in Plasma 6.2 and earlier, which
accidentally got increased in the big code refactor for 6.3.

Also fix a code error exposed by this change: a place where we were
accidentally using a layout's horizontal spacing as a vertical offset
elsewhere, instead of its vertical spacing.
FIXED-IN: 6.3.4

M  +1    -1    applets/notifications/package/contents/ui/delegates/BaseDelegate.qml
M  +1    -1    applets/notifications/package/contents/ui/delegates/DelegatePopup.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/a4d20ab762ce39401cf1d3b24895453169ff38ab
Comment 5 Nate Graham 2025-03-29 18:23:50 UTC
Git commit b2afca1a934f10f89778e580cd88c08ed35e49cd by Nate Graham.
Committed on 29/03/2025 at 17:51.
Pushed by ngraham into branch 'Plasma/6.3'.

applets/notifications: tighten internal spacings

This restores the spacing seen in Plasma 6.2 and earlier, which
accidentally got increased in the big code refactor for 6.3.

Also fix a code error exposed by this change: a place where we were
accidentally using a layout's horizontal spacing as a vertical offset
elsewhere, instead of its vertical spacing.
FIXED-IN: 6.3.4


(cherry picked from commit a4d20ab762ce39401cf1d3b24895453169ff38ab)

Co-authored-by: Nate Graham <nate@kde.org>

M  +1    -1    applets/notifications/package/contents/ui/delegates/BaseDelegate.qml
M  +1    -1    applets/notifications/package/contents/ui/delegates/DelegatePopup.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/b2afca1a934f10f89778e580cd88c08ed35e49cd