SUMMARY *** I have an album, this include 300 thousand photos. If I starting a search in the album, digikam does not feedback on search status. This is not a problem if the search is successful (digikam finds picture), but is a problem if the search is not successful (the screen is empty). Does the user not know if this operation is complete? In this case it would be good a message or a progress bar, to let the user know that the search is complete. *** STEPS TO REPRODUCE 1. Click left panel, Search tab 2. Search for an item
Can you make a try with current 7.6.0 appimage linux bundle to see if the problem still here ? https://files.kde.org/digikam/ Thanks in advance Gilles Caulier
(In reply to caulier.gilles from comment #1) > Can you make a try with current 7.6.0 appimage linux bundle to see if the > problem still here ? > > https://files.kde.org/digikam/ > > Thanks in advance > > Gilles Caulier Tested in digiKam 7.5 and 7.6: digiKam does not provide feedback on the status of the search process. Search is very fast, but it is not possible to know that the operation is complete. If there are no hits and the screen is blank, the user does not know what is happening... ...is digikam searching or is the search complete?
Created attachment 145872 [details] message.patch @Gilles, Is this popup message good/bad or even annoying. Should it only come with the search or leave it out altogether? This was just a quick idea to test. Maik
Hi Maik, yes exactly, using the DNotificationWidget is the right way i think. It's not too much intrusive and enough visible to warn user. Gilles
Git commit 0eaf6c4428954d2a1ba566d403ff55279fc96a5e by Maik Qualmann. Committed on 24/01/2022 at 21:07. Pushed by mqualmann into branch 'master'. Show message if there was no result from the query This also fixes a bug in the DNotificationWidget. It used startTimer() without QObject's killTimer(). Each startTimer() call creates a new timer and the timer event runs faster and faster. FIXED-IN: 7.6.0 M +1 -1 NEWS M +11 -0 core/app/views/stack/itemiconview.cpp M +5 -0 core/app/views/stack/itemiconview.h M +34 -0 core/app/views/stack/itemiconview_items.cpp M +2 -0 core/app/views/stack/itemiconview_p.h M +8 -2 core/libs/notificationmanager/dnotificationwidget.cpp M +4 -1 core/libs/notificationmanager/dnotificationwidget.h M +4 -0 core/libs/notificationmanager/dnotificationwidget_p.cpp M +2 -0 core/libs/notificationmanager/dnotificationwidget_p.h https://invent.kde.org/graphics/digikam/commit/0eaf6c4428954d2a1ba566d403ff55279fc96a5e
Hi Maik. I tested it (in digikam 7.6.0 appimage), but this patch is not working properly. - Open digikam and click Search tab. - Write in search field, example: xyz - Press Enter - "The current queri from the database..." message is displayed. This OK, but now... - Look for what is sure to hit, but let it be short (so there will be a lot of result). Example: th - "The current queri from the database..." message is displayed and the thumbnails too... ...it looks as if digikam is freezing, but eventually it goes on. ...and now: - Write in search field, example: xyz - Press Enter - "The current queri from the database..." message is not displayed. - Write in search field, example: xyz - Press Enter - "The current queri from the database..." message is displayed. Here a screen catch: https://mega.nz/file/ER42EDYJ#m6HWJsNrxm493mVhl0goqSQ2t0WJbI3XhT5rJj4coFM
Git commit f5b18bdf78bf0e7c75e39da2f9c1520759270530 by Maik Qualmann. Committed on 25/01/2022 at 20:37. Pushed by mqualmann into branch 'master'. we need process events between signal and read the items count FIXED-IN: 7.6.0 M +2 -2 core/app/views/stack/itemiconview.cpp M +0 -1 core/app/views/stack/itemiconview.h M +7 -14 core/app/views/stack/itemiconview_items.cpp M +1 -1 core/libs/database/tags/facetagseditor.cpp https://invent.kde.org/graphics/digikam/commit/f5b18bdf78bf0e7c75e39da2f9c1520759270530
Your freeze (the time is not counting down) and the incorrect display of existing items is strange and I can't reproduce it here at the moment. You will have to test that. Maik
(In reply to Maik Qualmann from comment #8) > Your freeze (the time is not counting down) and the incorrect display of > existing items is strange and I can't reproduce it here at the moment. You > will have to test that. > > Maik OK.
(In reply to Peter from comment #9) > (In reply to Maik Qualmann from comment #8) > > Your freeze (the time is not counting down) and the incorrect display of > > existing items is strange and I can't reproduce it here at the moment. You > > will have to test that. > > > > Maik > Hi Maik. I tested it and works well. Excellent. Thank You! " Your freeze (the time is not counting down) and the incorrect..." This is because: too many hits and too slow machine. So it's not a fault. Regards Peter
Git commit 78b5485255b83085eea86d3fd2d3a515bda53c87 by Maik Qualmann. Committed on 08/03/2022 at 07:12. Pushed by mqualmann into branch 'qt5-maintenance'. show empty album message only with search albums Related: bug 451256 FIXED-IN: 7.7.0 M +2 -1 NEWS M +1 -1 core/app/views/stack/itemiconview_items.cpp https://invent.kde.org/graphics/digikam/commit/78b5485255b83085eea86d3fd2d3a515bda53c87