Bug 449040 - The headers in KCM pages have different paddings
Summary: The headers in KCM pages have different paddings
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: iconview (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-23 23:41 UTC by Photon
Modified: 2022-02-01 19:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.24


Attachments
Different padding 1 (82.40 KB, image/png)
2022-01-23 23:41 UTC, Photon
Details
Different padding 2 (60.06 KB, image/png)
2022-01-23 23:41 UTC, Photon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Photon 2022-01-23 23:41:18 UTC
Created attachment 145824 [details]
Different padding 1

SUMMARY


STEPS TO REPRODUCE
Switch to icon-view in System Settings and open different pages.

OBSERVED RESULT


EXPECTED RESULT
The headers in KCM pages having the same padding.

SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 35
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.2
Kernel Version: 5.15.16-200.fc35.x86_64 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i5-8265U CPU @ 1.60GHz
Memory: 15.5 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620

ADDITIONAL INFORMATION
Comment 1 Photon 2022-01-23 23:41:42 UTC
Created attachment 145825 [details]
Different padding 2
Comment 2 Photon 2022-01-23 23:42:42 UTC
Note that the "General Behavior" have a little extra vertical padding.
Comment 3 Nate Graham 2022-01-24 00:46:47 UTC

*** This bug has been marked as a duplicate of bug 448889 ***
Comment 4 Nate Graham 2022-01-24 00:47:29 UTC
Oops my mistake, this is a different thing.
Comment 5 Bug Janitor Service 2022-01-31 23:22:48 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/121
Comment 6 Ismael Asensio 2022-02-01 19:45:39 UTC
Git commit ed64dbc76457bc66eaf565bf57ea0bf379cf4c59 by Ismael Asensio.
Committed on 01/02/2022 at 19:31.
Pushed by ngraham into branch 'master'.

IconView: Fix header padding

We weren't setting the vertical spacing for the page's GridLayout,
so it took the standard 6px causing this extra padding on top and
bottom for every KCM.

Better apply this margins to the title widget which is only shown
for iconview.

The horizontal spacing is not needed, so that part can be simplified.
FIXED-IN: 5.24

M  +7    -4    core/ModuleView.cpp

https://invent.kde.org/plasma/systemsettings/commit/ed64dbc76457bc66eaf565bf57ea0bf379cf4c59
Comment 7 Nate Graham 2022-02-01 19:46:41 UTC
Git commit b3fff86075e3cf469fa38f400c2a48006c68ee91 by Nate Graham, on behalf of Ismael Asensio.
Committed on 01/02/2022 at 19:46.
Pushed by ngraham into branch 'Plasma/5.24'.

IconView: Fix header padding

We weren't setting the vertical spacing for the page's GridLayout,
so it took the standard 6px causing this extra padding on top and
bottom for every KCM.

Better apply this margins to the title widget which is only shown
for iconview.

The horizontal spacing is not needed, so that part can be simplified.
FIXED-IN: 5.24


(cherry picked from commit ed64dbc76457bc66eaf565bf57ea0bf379cf4c59)

M  +7    -4    core/ModuleView.cpp

https://invent.kde.org/plasma/systemsettings/commit/b3fff86075e3cf469fa38f400c2a48006c68ee91