Bug 448946 - Nightcolor starts querying location automatically when activated before informed consent text has been shown
Summary: Nightcolor starts querying location automatically when activated before infor...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_nightcolor (other bugs)
Version First Reported In: 5.23.90
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-22 13:04 UTC by postix
Modified: 2022-12-06 17:20 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.26
Sentry Crash Report:


Attachments
Screenrecording of the current situation (761.09 KB, video/mp4)
2022-01-22 13:41 UTC, postix
Details
Screenshot: Descrption of the idea (234.35 KB, image/png)
2022-02-02 19:46 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2022-01-22 13:04:23 UTC
SUMMARY

With the latest change the text that Nightcolor uses "Mozilla Location Service" in case of "Sunset to sunrise at current location" has been hidden, until Nightcolor becomes activated in the Systemsettings.

Once activated, it immediately starts querying. After considering it again, I'd suggest the following solution having privacy in mind:

* Keep the combobox and the slider always active, independent of the Nightcolor's state: There's no reason not to already choose the activation time, if nightcolor is disabled.
* Show always the text, so that the user knows, what happens, once it becomes activated.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon Testing
KDE Plasma Version: 5.23.90
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Comment 1 postix 2022-01-22 13:41:06 UTC
Created attachment 145750 [details]
Screenrecording of the current situation
Comment 2 Bharadwaj Raju 2022-01-23 21:35:26 UTC
I think it would be better to add some way to let the user confirm before starting geolocation instead.
Comment 3 postix 2022-02-02 19:46:31 UTC
Created attachment 146189 [details]
Screenshot: Descrption of the idea

Let me propose another solution to the whole problem, which in my opinion makes most sense:

Let's get rid of "Set sunrise at current location" and rename "Set sunrise at manual location" to "Set sunrise at location" to combine both:
There you simply add a (by default unchecked) checkbox below the "Detect location" button reading something like 
"Update location automatically".
Comment 4 postix 2022-02-02 20:15:59 UTC
Or forget about my comment 3, as I see that it may complicate things a lot. Sorry for the noise!
Comment 5 Bharadwaj Raju 2022-12-06 13:30:24 UTC
In the present state, Off is also part of the combobox so the user can completely avoid ever using the "Current location" option. Does that resolve this?
Comment 6 Nate Graham 2022-12-06 17:20:51 UTC
Yep, this should be fixed now. When you choose the "Current Location" option, you'll see the message about geolocating before it actually does it; you have to click "Apply" before it will start geolocating. This gives you an opportunity to choose another setting that doesn't require geolocation.