https://www.openstreetmap.org/node/5520566326 Current Input: Su-Sa PH closed Current Suggestion: PH Su-Sa closed I am seeing this occasionally, please help me understand if this is valid. I suspect the current value means: Su-Sa ~or~ PH, this is "closed". I am reading the proposed value suspect the current value means: if PH ~and~ Su-Sa, then this is "closed". https://openingh.openstreetmap.de/evaluation_tool/ says that both values are the same. Another possible issue: there is no problem with the initial issue, the proposed fix is cosmetic, should not have been flaged. Thanks for reading this far!
I'm pretty sure that in order to say "or" you have to write "Su-Sa,PH closed" with a comma. See for instance the text under "There can be two cases" at https://github.com/opening-hours/opening_hours.js#holidays We could improve KOpeningHours so that it suggests "Su-Sa,PH" for "Su-Sa PH", since it's likely more common than "PH Su-Sa", but this is all just guess-work of what the original author might have meant. In any case "Su-Sa PH" is invalid, according to the grammar.
This helped me understand, thank you. I agree with "Su-Sa PH" -> "Su-Sa,PH" autoconversion, it seems a more likely guess over the current suggestion "PH Su-Sa closed". I started adding "fixme" or adding changeset comments asking locals and the original editors for re-survey or to do fixes related to opening_hours. In the few months I did that, I got zero responses. So realistically, the best-guess approach may be the only way forward most of the time.