Bug 448727 - Nightcolor queries location online by default even if it's disabled causing privacy issues
Summary: Nightcolor queries location online by default even if it's disabled causing p...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_nightcolor (other bugs)
Version First Reported In: 5.23.90
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-18 17:10 UTC by postix
Modified: 2022-01-21 03:05 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.24
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2022-01-18 17:10:06 UTC
SUMMARY

Night color is deactivated (by default). Also by default 'Sunrise at current location' is pre-set.
This results in the following:

Whenever opening the KCM will first display the location 0°/0° and then query the location by contacting Mozilla / Amazon AWS server [1] for a fraction of a second and change it to  X°/Y°.

I would propose the following changes here:

1) Change the default value of "Sunrise at current custom location" and let the custom location be defined be the user's set local time zone
2) Cache the last known position in case of "Sunrise at current location", in case the computer has no internet connection
3) If possible, in sake of privacy, let the user choose a custom provider for the location

[1] ec2-35-163-112-241.us-west-2.compute.amazonaws.com

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon Unstanble
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Comment 1 Nate Graham 2022-01-20 21:48:42 UTC
Ooh not good.

We should just not make a connection at all if the feature is disabled in the KCM.
Comment 2 postix 2022-01-20 21:57:07 UTC
(In reply to Nate Graham from comment #1)
> We should just not make a connection at all if the feature is disabled in
> the KCM.

Maybe also not automatically or directly, when the feature becomes enabled. In order to choose the activation time, you need to enable it. When you now click through all the options and pick "'Sunrise at current location" it will query it before you even know what's going on. 

Thus maybe this option can have a consent checkbox: "[ ] Query automatically" and a "Query now" button.
Comment 3 Bug Janitor Service 2022-01-20 23:00:35 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1387
Comment 4 Nate Graham 2022-01-21 03:05:18 UTC
Git commit d1f2984341fb224a7a7ebb1c4d633189ec917f17 by Nate Graham, on behalf of Bharadwaj Raju.
Committed on 21/01/2022 at 03:05.
Pushed by ngraham into branch 'master'.

kcms/nightcolor: Don't start locator if Night Color is not active
Related: bug 448728
FIXED-IN: 5.24

M  +16   -5    kcms/nightcolor/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/d1f2984341fb224a7a7ebb1c4d633189ec917f17
Comment 5 Nate Graham 2022-01-21 03:05:52 UTC
Git commit c491a3d2b3e648286756cc356d848028a612f935 by Nate Graham, on behalf of Bharadwaj Raju.
Committed on 21/01/2022 at 03:05.
Pushed by ngraham into branch 'Plasma/5.24'.

kcms/nightcolor: Don't start locator if Night Color is not active
Related: bug 448728
FIXED-IN: 5.24


(cherry picked from commit d1f2984341fb224a7a7ebb1c4d633189ec917f17)

M  +16   -5    kcms/nightcolor/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/c491a3d2b3e648286756cc356d848028a612f935