Bug 448359 - The error of krita's own tag
Summary: The error of krita's own tag
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tagging (show other bugs)
Version: 5.0.2
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Tiar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-13 12:50 UTC by thetwo
Modified: 2022-03-31 21:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
bug1 (317.65 KB, image/gif)
2022-01-13 12:50 UTC, thetwo 		Details
bug2 (1.17 MB, image/gif)
2022-01-13 12:51 UTC, thetwo 		Details
bug2‘ (907.03 KB, image/gif)
2022-01-13 12:52 UTC, thetwo 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description thetwo 2022-01-13 12:50:49 UTC 
Created attachment 145400 [details]
bug1

It's obvious in the gif
bug1: Add a brush to the built-in tag, and a new brush will appear
bug2: Brush panel and right-click menu will not synchronize brushes with tags
Comment 1 thetwo 2022-01-13 12:51:25 UTC 
Created attachment 145401 [details]
bug2
Comment 2 thetwo 2022-01-13 12:52:08 UTC 
Created attachment 145402 [details]
bug2‘
Comment 3 Tiar 2022-01-13 18:40:54 UTC 
Could you please check if it only happens when the preset was already tagged with that tag before?
Maybe the cause is that KisTagResourcesModel::tagResource(), in case the resource has been tagged with that tag before, gives an incorrect row value as "added". Qt views might get confused.

Btw we need this function to accept multiple resource ids for performance reasons (see https://krita-artists.org/t/fighting-with-new-improved-resource-system/35020).
Comment 4 thetwo 2022-01-14 07:07:32 UTC 
I use translation software, not very understand what you mean ......
Comment 5 Tiar 2022-03-31 19:55:56 UTC 
Does it still happen, if you download Krita Next and check there?
Comment 6 thetwo 2022-03-31 21:20:43 UTC 
(In reply to Tiar from comment #5)
> Does it still happen, if you download Krita Next and check there?

I just tested it and the bug didn't appear!