Bug 448330 - Various Plasma components' separator lines should have the same color
Summary: Various Plasma components' separator lines should have the same color
Status: CONFIRMED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.90.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-12 17:31 UTC by Photon
Modified: 2022-01-13 15:20 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Current design (29.79 KB, image/jpeg)
2022-01-12 17:31 UTC, Photon
Details
Proposed design (47.62 KB, image/jpeg)
2022-01-12 17:31 UTC, Photon
Details
Current design (153.57 KB, image/png)
2022-01-12 17:33 UTC, Photon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Photon 2022-01-12 17:31:27 UTC
Created attachment 145375 [details]
Current design

Currently, there are four separator lines, each one of them have a shade of grey, which looks super odd. It would be better if all the lines had the same color.

Note: I'm using the default Breeze color scheme and Plasma Style.
Comment 1 Photon 2022-01-12 17:31:43 UTC
Created attachment 145376 [details]
Proposed design
Comment 2 Photon 2022-01-12 17:33:50 UTC
Created attachment 145377 [details]
Current design
Comment 3 Nate Graham 2022-01-13 04:45:31 UTC
This will be tricky to solve because these lines all come from different UI components. Thankfully they all live in plasma framework:

The horizontal lines come from PlasmaExtras.PlasmoidHeading

The vertical lines come from PlasmaComponents3.ScrollView and the vertical separator SVG

So it's feasible to fix them all in one commit.
Comment 4 Marco Martin 2022-01-13 09:30:40 UTC
in that particular design, the line at the right of the scrollbar should definitely be the same color of the bottom footer line, tough i think is actually correct that the line on the left is fainter, it wouldn't communicate well which panel the scrollbar belongs otherwise (i know is usually on the right and that can be assumed, but here is helping of split second unconscious perception)
Comment 5 Photon 2022-01-13 13:54:11 UTC
Well, maybe the top and the bottom lines could have the same color and the scrollbar lines, a different color.

Analyzing the picture I posted, the bottom line is #4b4f53; top is #4e545b, left (scrollbar) is #445362, right (scrollbar) is #576673 (not considering the alpha channel. I said that they have different shades of grey, but I think they are semi-transparent lines).
Comment 6 Nate Graham 2022-01-13 15:20:03 UTC
Yeah I think it's reasonable for all of them to have the same color except for the scrollbar's left line, which would be lighter. That wouldn't seem random IMO.