Bug 448327 - Combine the Help and About buttons and change the Settings button to "Configure" and make the later button aligned to the left
Summary: Combine the Help and About buttons and change the Settings button to "Configu...
Status: RESOLVED FIXED
Alias: None
Product: Skanlite
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kåre Särs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-12 15:22 UTC by Photon
Modified: 2022-01-20 18:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Spectacle and Skanlite (93.96 KB, image/png)
2022-01-12 15:22 UTC, Photon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Photon 2022-01-12 15:22:17 UTC
Created attachment 145369 [details]
Spectacle and Skanlite

In Spectacle, the about information is inside the Help button. However, in Skanlite there is two separate buttons for that. I think it would be better to change Skanlite to follow the same design of Spectacle. Also, this would help to clean the UI a little bit.
Comment 1 Photon 2022-01-12 15:24:05 UTC
Also, I think the Settings button should be changed to "Configure" and it should be aligned to the left, just like Spectacle.
Comment 2 Photon 2022-01-12 15:24:33 UTC
Maybe the close button should be removed too. There is already a close button in titlebar for that.
Comment 3 Nate Graham 2022-01-13 21:16:00 UTC
Seems reasonable to me.
Comment 4 Bug Janitor Service 2022-01-17 15:20:58 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/skanlite/-/merge_requests/28
Comment 5 Eric Armbruster 2022-01-20 18:11:46 UTC
Git commit f46a0340769d1f2b37fdc4d9bd4218dac8473a19 by Eric Armbruster, on behalf of Eric Armbruster.
Committed on 17/01/2022 at 15:08.
Pushed by sars into branch 'master'.

Change button layout to match spectacle

In order to achieve more consistency across KDE apps this commit
- removes the superfluous close button
- renames the configure button and left aligns it
- moves the about button into the help menu

M  +13   -12   src/skanlite.cpp
M  +0    -1    src/skanlite.h

https://invent.kde.org/graphics/skanlite/commit/f46a0340769d1f2b37fdc4d9bd4218dac8473a19