Bug 448045 - Reduce intensity of Colour Labels Displayed in Album/Thumbnail View or Replace with Discreet Colour Label
Summary: Reduce intensity of Colour Labels Displayed in Album/Thumbnail View or Replac...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-IconView (show other bugs)
Version: 7.4.0
Platform: macOS (DMG) macOS
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-07 00:42 UTC by PeterJ
Modified: 2024-09-22 23:26 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.5.0
Sentry Crash Report:


Attachments
digikam Album Thumbnails - Feature Request (1.36 MB, image/jpeg)
2022-01-07 00:42 UTC, PeterJ
Details
Configure/View dialog screen shot - before edits (129.79 KB, image/jpeg)
2023-01-30 17:59 UTC, David Haslam
Details
Configure/View dialog screen shot - after edits (135.43 KB, image/jpeg)
2023-01-30 17:59 UTC, David Haslam
Details
colorline (559.24 KB, image/png)
2024-09-17 20:19 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description PeterJ 2022-01-07 00:42:26 UTC
Created attachment 145177 [details]
digikam Album Thumbnails - Feature Request

SUMMARY
***
FEATURE REQUEST

When viewing Image Thumbnails in Album View, the brightly coloured 'Label' border around each image can be very distracting if several different Labels are used in an Album.

Would it be possible to provide a 'Label Intensity' option so the labels are less distracting when viewing image Thumbnails please, or perhaps remove the coloured border and replace with a coloured line as shown in the attached screenshots?

Thanks
Comment 1 Maik Qualmann 2022-01-07 07:34:50 UTC
I like the idea with a kind of line or a narrower representation of the color label. I've already experimented a little, there is no space for it under the file name or within the information lines in the thumbnail. We would have to reserve space that would unnecessarily enlarge the thumbnails. Let's see what else I can think of ... 

Maik
Comment 2 PeterJ 2022-01-07 09:18:43 UTC
Thanks Mark,
It will be great if you can come up with something to make those 
highlights less distracting.
Warm regards
Peter

Maik Qualmann wrote on 07/01/2022 17:34:50:
> https://bugs.kde.org/show_bug.cgi?id=448045
>
> Maik Qualmann <metzpinguin@gmail.com> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                   CC|                            |metzpinguin@gmail.com
>
> --- Comment #1 from Maik Qualmann <metzpinguin@gmail.com> ---
> I like the idea with a kind of line or a narrower representation of the color
> label. I've already experimented a little, there is no space for it under the
> file name or within the information lines in the thumbnail. We would have to
> reserve space that would unnecessarily enlarge the thumbnails. Let's see what
> else I can think of ...
>
> Maik
>
Comment 3 caulier.gilles 2022-01-07 11:13:42 UTC
Hi,

As Maik, i found your mock-up interesting and optimum.

Q : i remember to code this kind of solution in the pass because some users ask a good visibility/usability for this feature. If we switch to this kind of solution, i' sure to see report back in this room. So, do we need to set an option for that ?

Best

Gilles Caulier
Comment 4 David Haslam 2023-01-30 17:58:01 UTC
I find there are times when I want to see the color borders, other
times they are a distraction. So a simple fix that works for me is to
provide a configuration option to turn it on and off completely.

How useful this is to other users probably depends on what they use
color labels for.

I found coding this straightforward. Attempts to add a new way of
representing the color label were not so straightforward.

For completeness I also coded an option to control the pick label.

I'll attach before and after screenshots of the Configure->Views dialog.

I hope to send a merge request shortly for review.

Thanks,
David
Comment 5 David Haslam 2023-01-30 17:59:26 UTC
Created attachment 155791 [details]
Configure/View dialog screen shot - before edits
Comment 6 David Haslam 2023-01-30 17:59:49 UTC
Created attachment 155792 [details]
Configure/View dialog screen shot - after edits
Comment 7 caulier.gilles 2023-05-14 13:15:20 UTC
Maik,

Perhaps the good compromise is to draw only the horizontal lines on to and bottom of thumbnails ?

Gilles
Comment 8 caulier.gilles 2024-09-17 16:07:43 UTC
Maik,

After some time, i think the horizontal line to draw the color label will be less intrusive in GUI and will allows to safe space on the thumbnails view.

Gilles
Comment 9 Maik Qualmann 2024-09-17 16:29:33 UTC
I also like the horizontal line, but as I wrote in comment 1, we don't really have any free space between the file name and the title. I would try the bottom edge of the thumbnail.

Maik
Comment 10 Maik Qualmann 2024-09-17 20:19:35 UTC
Created attachment 173793 [details]
colorline

Example with line under the thumbnail, image "Natur-306.jpg" has a black line that is practically invisible in a dark color scheme.

Maik
Comment 11 caulier.gilles 2024-09-18 04:01:37 UTC
Maik, 

I really like the horizontal color line solution as color label.

For the black label, i suppose that the readability problem is the same with the current color label solution?

Gilles
Comment 12 caulier.gilles 2024-09-18 04:03:26 UTC
Perhaps a single frame around the line rectangle can be a solution, using the opposite color of the color label to increase the contrast ?

Gilles
Comment 13 Maik Qualmann 2024-09-18 06:15:04 UTC
Yes, the problem is the same with the black color label with the current solution.
I will commit the new solution first, we can always make adjustments based on feedback.

Maik
Comment 14 caulier.gilles 2024-09-18 06:20:57 UTC
yes, perfect
Gilles
Comment 15 Maik Qualmann 2024-09-18 06:28:54 UTC
Git commit 3456bc86b2229d7796886f899085420cbf1398b0 by Maik Qualmann.
Committed on 18/09/2024 at 06:27.
Pushed by mqualmann into branch 'master'.

use a line under the thumbnail for the color label
FIXED-IN: 8.5.0

M  +1    -1    NEWS
M  +2    -2    core/app/items/delegate/itemdelegate.cpp
M  +28   -17   core/libs/widgets/itemview/itemviewdelegate.cpp
M  +1    -1    core/libs/widgets/itemview/itemviewdelegate.h
M  +2    -2    core/utilities/import/items/importdelegate.cpp
M  +26   -17   core/utilities/import/items/itemviewimportdelegate.cpp
M  +1    -1    core/utilities/import/items/itemviewimportdelegate.h

https://invent.kde.org/graphics/digikam/-/commit/3456bc86b2229d7796886f899085420cbf1398b0
Comment 16 PeterJ 2024-09-22 23:26:20 UTC
A big thank you to those involved in solving this issue. 
I think the new coloured line removes the distraction from the thumbnail images that the old layout exhibited. 
And it also looks sophisticated and modern. 😁👍
Cheers
Peter

> On 18 Sep 2024, at 2:01 PM, bugzilla_noreply@kde.org wrote:
> 
> https://bugs.kde.org/show_bug.cgi?id=448045
> 
> --- Comment #11 from caulier.gilles@gmail.com ---
> Maik,
> 
> I really like the horizontal color line solution as color label.
> 
> For the black label, i suppose that the readability problem is the same with
> the current color label solution?
> 
> Gilles
> 
> --
> You are receiving this mail because:
> You reported the bug.