Bug 448025 - Images with specific size in clipboard make the preview image wiggle
Summary: Images with specific size in clipboard make the preview image wiggle
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Clipboard (show other bugs)
Version: 5.23.5
Platform: Manjaro Linux
: VHI normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 448121 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-01-06 15:26 UTC by Antonio Prcela
Modified: 2022-01-09 22:28 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24


Attachments
screenshot and example image (79.76 KB, image/png)
2022-01-06 15:27 UTC, Antonio Prcela
Details
video with example (721.65 KB, video/webm)
2022-01-06 15:27 UTC, Antonio Prcela
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Prcela 2022-01-06 15:26:01 UTC
SUMMARY
Images with specific size in clipboard make the preview in notification wiggle

STEPS TO REPRODUCE
1. for example, take a screenshot with spectacle and save the image into the clipboard
2. check Clipboard

OBSERVED RESULT
image preview wiggles

EXPECTED RESULT
image preview should be static :)

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.2
Kernel Version: 5.15.12-1-MANJARO (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 2700X Eight-Core Processor
Memory: 15,6 GiB of RAM
Graphics Processor: AMD Radeon RX 570 Series

ADDITIONAL INFORMATION
Screen resolution: 3840x2160
Scaling set to 125%
Refresh rate 60Hz
Image size: see attached image, 1.601x1.369
Comment 1 Antonio Prcela 2022-01-06 15:27:39 UTC
Created attachment 145162 [details]
screenshot and example image
Comment 2 Antonio Prcela 2022-01-06 15:27:58 UTC
Created attachment 145163 [details]
video with example
Comment 3 David Edmundson 2022-01-09 21:23:53 UTC
*** Bug 448121 has been marked as a duplicate of this bug. ***
Comment 4 David Edmundson 2022-01-09 21:25:41 UTC
Causing commit: https://invent.kde.org/plasma/plasma-workspace/-/commit/d92cfc2f9ba43bebaf85912749cf68db09333a9a

Worst case we can revert, but hopefully a solution can be found
Comment 5 ratijas 2022-01-09 21:31:15 UTC
I copied the image from the browser (right click -> copy image), and can't reproduce. My clipboard applet is in system tray, default size.

Maybe latest scrollview changes have caused/fixed this?
Comment 6 Nate Graham 2022-01-09 21:32:02 UTC
I cannot reproduce any wiggling with current git master when I copy an image to the clipboard from Spectacle or any other means.

I'm using Wayland and this bug report comes from X11; could that be a factor maybe? Somehow?
Comment 7 Nate Graham 2022-01-09 21:33:40 UTC
Looks like the latest scrollview changes has indeed fixed this, as the screen recording depicts the clipboard applet without it in Plasma 5.23.5.
Comment 8 ratijas 2022-01-09 21:33:58 UTC
Also, I noticed the image posted is not exactly the same as in the video. Are they of the same size?

I'm on X11 by the way
Comment 9 Antonio Prcela 2022-01-09 22:08:51 UTC
I doubt that this commit is causing it: https://invent.kde.org/plasma/plasma-workspace/-/commit/d92cfc2f9ba43bebaf85912749cf68db09333a9a

Had this pop up in the last few months.

I can reproduce it again: take a rectangle screenshot with spectacle and make it the size of the window in the posted screenshot. Copy to clipboard.
Mind you, screen res: 3840x2160, scaling 125% - can anyone try with this setting?

@ratijas it's the exact screenshot seen in the notification and posted here

@Nate - `Looks like the latest scrollview changes` - nice! what commit and what release will it be in?
Comment 10 David Edmundson 2022-01-09 22:11:50 UTC
Seems I got that backwards then.

>I'm using Wayland and this bug report comes from X11; could that be a factor maybe? Somehow?

I doubt it. 

It'll be the: I don't have room to fit so I'll show a scrollbar, that changes the width, with certain aspect ratios that will then change the height which changes if you need a scollbar. Glad the new code might fix it.

That new code is in Plasma 5.25 (aka next). Please reopen if it's still an issue afterwards
Comment 11 Nate Graham 2022-01-09 22:24:42 UTC
(In reply to Antonio Prcela from comment #9)
> @Nate - `Looks like the latest scrollview changes` - nice! what commit and
> what release will it be in?
Should be https://invent.kde.org/plasma/plasma-workspace/-/commit/d92cfc2f9ba43bebaf85912749cf68db09333a9a in 5.24.
Comment 12 ratijas 2022-01-09 22:27:49 UTC
> It'll be the: I don't have room to fit so I'll show a scrollbar, that changes the width, with certain aspect ratios that will then change the height which changes if you need a scollbar. Glad the new code might fix it.

Still can't reproduce with only this image in clipboard history
Comment 13 Nate Graham 2022-01-09 22:28:44 UTC
I just tested out David's theory by generating clipboard items that just barely don't fit vertically, and could not reproduce the issue, thankfully.