Bug 448016 - Invisible rating controls taking up space at the list views
Summary: Invisible rating controls taking up space at the list views
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: 21.12.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-06 12:00 UTC by Nagy Tibor
Modified: 2022-01-29 18:41 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/multimedia/elisa/commit/667fd8ef2e1dea0cd926ccbbfdcdf672f959c1af
Version Fixed/Implemented In: 21.12.2
Sentry Crash Report:

Attachments
Screenshot (312.67 KB, image/png)
2022-01-06 12:00 UTC, Nagy Tibor 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nagy Tibor 2022-01-06 12:00:49 UTC 
Created attachment 145156 [details]
Screenshot

SUMMARY
When you have the song rating style set to "0-5 stars", the star rating controls always take up space in Elisa's list views, even if they are invisible. Every list view having these rating controls are affected.

This issue does not occur with the "Favorite/not favorite" style buttons.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Nate Graham 2022-01-12 20:43:09 UTC 
Can reproduce with "0-5 stars" style, but not with "favorite/not favorite" style.
Comment 2 Nate Graham 2022-01-29 18:41:57 UTC 
Git commit 667fd8ef2e1dea0cd926ccbbfdcdf672f959c1af by Nate Graham.
Committed on 29/01/2022 at 18:40.
Pushed by ngraham into branch 'release/21.12'.

Don't let rating stars take up space for unrated tracks

Thr favorite style rating star was correctly set to hide itself for
unrated tracks, but the 1-5 star widget was not, so it always consumed
space in the layout and could cause track titles to be elided too early.
FIXED-IN: 21.12.2

M  +1    -1    src/qml/ListBrowserDelegate.qml

https://invent.kde.org/multimedia/elisa/commit/667fd8ef2e1dea0cd926ccbbfdcdf672f959c1af