Bug 447826 - Undo button at the "Playlist cleared" notification shouldn't use cancel icon
Summary: Undo button at the "Playlist cleared" notification shouldn't use cancel icon
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: 21.12.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-02 12:42 UTC by Nagy Tibor
Modified: 2022-01-04 04:24 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 22.04
Sentry Crash Report:


Attachments
Screenshot (46.24 KB, image/png)
2022-01-02 12:42 UTC, Nagy Tibor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nagy Tibor 2022-01-02 12:42:35 UTC
Created attachment 145049 [details]
Screenshot

SUMMARY
After clearing the current playlist with the "Clear All" button Elisa throws a "Playlist cleared" notification that allows undoing this action. The undo button on this notification uses a semantically incorrect icon, a "cancel" icon instead of an "undo" icon.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Bug Janitor Service 2022-01-03 20:05:58 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/316
Comment 2 Nate Graham 2022-01-04 04:19:37 UTC
Git commit 7a8a311f71599b95dfd58f3f97ee10ca694b930f by Nate Graham, on behalf of Jack Hill.
Committed on 04/01/2022 at 04:19.
Pushed by ngraham into branch 'master'.

Changed clear playlist icon to "undo" icon

Previously the notification used the "cancel" icon.

M  +1    -1    src/qml/MediaPlayListView.qml

https://invent.kde.org/multimedia/elisa/commit/7a8a311f71599b95dfd58f3f97ee10ca694b930f