Bug 447510 - digikam.exe meta data is missing
Summary: digikam.exe meta data is missing
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Bundle-Windows (show other bugs)
Version: 7.4.0
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-25 17:23 UTC by Steve Magruder
Modified: 2021-12-26 22:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0
Sentry Crash Report:


Attachments
digikam.exe properties, details tab (41.55 KB, image/png)
2021-12-25 17:23 UTC, Steve Magruder
Details
dk-metadata.png (60.16 KB, image/png)
2021-12-26 18:39 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Magruder 2021-12-25 17:23:06 UTC
Created attachment 144859 [details]
digikam.exe properties, details tab

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
The meta data for digikam.exe is largely missing. See the attached image. Descriptions and versions are particularly missing. The software update monitor app I use relies on this meta data being there. I assume other such apps are expecting this data to be there. On top of that, it’s seemingly the norm for this data to be filled in.

STEPS TO REPRODUCE
1. Find digikam.exe on your Windows computer under c:\Program Files\digiKam.
2. Right-click the digikam.exe file and select Properties.
3. Select the Details tab, where you'll see meta data is largely missing.

OBSERVED RESULT
Meta data is largely missing.

EXPECTED RESULT
Meta data is filled in.

SOFTWARE/OS VERSIONS
Windows: Windows 10 21H2 Build 19044.1415
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2021-12-25 18:14:42 UTC
A solution based on Cmake is given in this thread : https://forum.qt.io/topic/122430/setting-up-the-application-information-in-cmake
Comment 2 caulier.gilles 2021-12-25 21:07:45 UTC
This is how Krita populate the binary metadata under Windows with this rc file :

https://invent.kde.org/graphics/krita/-/blob/master/krita/versioninfo.rc.in

And how CMake use this resource file under Windows :

https://invent.kde.org/graphics/krita/-/blob/master/krita/CMakeLists.txt#L156

Gilles Caulier
Comment 3 caulier.gilles 2021-12-26 13:56:48 UTC
Git commit 7ca7bf03b11ae72842006af8a66ed02894a4a605 by Gilles Caulier.
Committed on 26/12/2021 at 13:38.
Pushed by cgilles into branch 'master'.

Add version metadata for Windows executable
Factoring properties between Windows and MacOS bundles

M  +25   -12   core/app/DigikamTarget.cmake
M  +9    -9    core/cmake/templates/Info.plist.cmake.in
A  +38   -0    core/cmake/templates/versioninfo.rc.cmake.in
M  +28   -13   core/showfoto/CMakeLists.txt

https://invent.kde.org/graphics/digikam/commit/7ca7bf03b11ae72842006af8a66ed02894a4a605
Comment 4 caulier.gilles 2021-12-26 18:02:44 UTC
Steve,

digiKam-7.5.0-20211226T172519-Win64.exe will be online in few minutes at usual place :

https://files.kde.org/digikam/

Please download this installer and look if the problem is fixed.

Thanks in advance

Gilles Caulier
Comment 5 caulier.gilles 2021-12-26 18:11:18 UTC
If i look with ExifTool, i can see :

[gilles@localhost Downloads]$ exiftool digikam.exe 
ExifTool Version Number         : 12.00
File Name                       : digikam.exe
Directory                       : .
File Size                       : 222 kB
File Modification Date/Time     : 2021:12:26 18:51:46+01:00
File Access Date/Time           : 0000:00:00 00:00:00
File Inode Change Date/Time     : 2021:12:26 19:08:50+01:00
File Permissions                : rwxr-xr-x
File Type                       : Win64 EXE
File Type Extension             : exe
MIME Type                       : application/octet-stream
Machine Type                    : AMD AMD64
Time Stamp                      : 0000:00:00 00:00:00
Image File Characteristics      : No relocs, Executable, No line numbers, No symbols, Large address aware, No debug
PE Type                         : PE32+
Linker Version                  : 2.28
Code Size                       : 23040
Initialized Data Size           : 225792
Uninitialized Data Size         : 512
Entry Point                     : 0x14d0
OS Version                      : 4.0
Image Version                   : 0.0
Subsystem Version               : 5.2
Subsystem                       : Windows GUI
File Version Number             : 7.5.0.0                      <<==
Product Version Number          : 7.5.0.0                      <<==
File Flags Mask                 : 0x003f
File Flags                      : (none)
File OS                         : Win32
Object File Type                : Executable application
File Subtype                    : 0
Language Code                   : English (U.S.)
Character Set                   : Windows, Latin1
Company Name                    : digiKam.org                      <<==
File Description                : Advanced digital photo management application                      <<==
File Version                    : 7.5.0                      <<==
Internal Name                   : digikam                      <<==
Legal Copyright                 : digiKam.org                      <<==
Original File Name              : digikam.exe                      <<==
Product Name                    : digikam                      <<==
Product Version                 : 7.5.0                      <<==

I think all the data are set properly in executable.

Gilles Caulier
Comment 6 Maik Qualmann 2021-12-26 18:39:05 UTC
Created attachment 144881 [details]
dk-metadata.png

Hi Gilles, looks very good, see screenshot (German Windows). 

Maik
Comment 7 caulier.gilles 2021-12-26 19:26:39 UTC
Great... happy new year (:-)))...

Gilles
Comment 8 Steve Magruder 2021-12-26 22:12:56 UTC
(In reply to caulier.gilles from comment #4)
> Steve,
> 
> digiKam-7.5.0-20211226T172519-Win64.exe will be online in few minutes at
> usual place :
> 
> https://files.kde.org/digikam/
> 
> Please download this installer and look if the problem is fixed.
> 
> Thanks in advance
> 
> Gilles Caulier

It appears fixed to me. Thanks everyone for your good work!