Bug 447323 - Import from Discogs not fetching 'Catalog Number' tag
Summary: Import from Discogs not fetching 'Catalog Number' tag
Status: RESOLVED FIXED
Alias: None
Product: kid3
Classification: Applications
Component: general (show other bugs)
Version: 3.9.x
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Urs Fleisch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-21 09:26 UTC by vvkanz
Modified: 2021-12-26 05:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vvkanz 2021-12-21 09:26:21 UTC
Import from Discogs works, but it is not fetching 'Catalog Number' tag as it used to do. Real pity for me. I have been looking forward for the new version with the working Discogs import so much.

Anyway, huge thanks for your work! I love kid3
Comment 1 Urs Fleisch 2021-12-21 13:46:59 UTC
I am sorry to hear that the new release has not met your expectations. Could you please elaborate a bit more detailed what is expected and what is received, if possible with a link to the Discogs URL of one or more albums.

Unfortunately, the "standard" Discogs import is rather shaky because it depends on the HTML output coming from the Discogs server, and this output is changing a lot. I stopped counting how many commits with description "Fix Discogs import" I had to make in the past.

Have you tried the JSON API import? It is stable and uses the official Discogs API. You just have to get register at Discogs.com, get an API token, enter it in Kid3's Discogs import dialog and click "Save Settings" (this is described in the handbook). Maybe this will bring you the catalog numbers you are expecting.
Comment 2 vvkanz 2021-12-21 19:56:31 UTC
(In reply to Urs Fleisch from comment #1)
> I am sorry to hear that the new release has not met your expectations. Could
> you please elaborate a bit more detailed what is expected and what is
> received, if possible with a link to the Discogs URL of one or more albums.
> 
> Unfortunately, the "standard" Discogs import is rather shaky because it
> depends on the HTML output coming from the Discogs server, and this output
> is changing a lot. I stopped counting how many commits with description "Fix
> Discogs import" I had to make in the past.
> 
> Have you tried the JSON API import? It is stable and uses the official
> Discogs API. You just have to get register at Discogs.com, get an API token,
> enter it in Kid3's Discogs import dialog and click "Save Settings" (this is
> described in the handbook). Maybe this will bring you the catalog numbers
> you are expecting.

Yes, it worked with the token! Thank you very much, Urs!
Comment 3 Urs Fleisch 2021-12-25 11:52:46 UTC
Git commit b42118f59e01f254ce12627b937e9db8d4f5fbf4 by Urs Fleisch.
Committed on 25/12/2021 at 11:25.
Pushed by ufleisch into branch 'master'.

Fix Discogs import to find correct release

M  +36   -11   src/plugins/discogsimport/discogsimporter.cpp

https://invent.kde.org/multimedia/kid3/commit/b42118f59e01f254ce12627b937e9db8d4f5fbf4
Comment 4 Urs Fleisch 2021-12-25 12:01:53 UTC
I found a problem in the "standard" Discogs import, the one which is not using the API token. Could you test if the catalog numbers are imported correctly also without an API token? You can find the fixed version git20211225 in the development folder https://sourceforge.net/projects/kid3/files/kid3/development/.
Comment 5 vvkanz 2021-12-26 05:05:41 UTC
(In reply to Urs Fleisch from comment #4)
> I found a problem in the "standard" Discogs import, the one which is not
> using the API token. Could you test if the catalog numbers are imported
> correctly also without an API token? You can find the fixed version
> git20211225 in the development folder
> https://sourceforge.net/projects/kid3/files/kid3/development/.

Yes, in this version (git20211225) the catalog number are imported correctly in the standard import (without the token).